Closed Bug 1617240 Opened 4 years ago Closed 4 years ago

Reload remote tab from about:devtools-toolbox

Categories

(DevTools :: about:debugging, enhancement, P3)

enhancement

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: Harald, Assigned: davidwalsh)

References

(Blocks 1 open bug)

Details

User Story

When testing my developer site on my phone, I want to quickly reload to fetch new data or reset state, so that I don't have to open menus on my phone.

Attachments

(1 file)

Similar to bug 1617237.

Optional: Can we map F5 and variants to reload the remote page?

User Story: (updated)

The design for Reload button is provided from Victoria.
https://bugzilla.mozilla.org/attachment.cgi?id=9140285

And also, if possible, let's try to implement Back/Forward buttons as well in here since I think it takes not much time.

:daisuke I look forward to implementing this. Could you provide a bit of info on the technical side? i.e. how we can send the message to reload via remote debugging?

Thank you!

Assignee: nobody → dwalsh
Flags: needinfo?(daisuke)

Hi David! Thank you very much!

Regarding UI:
The component that shows the debuggee's name, URI and so on is DebugTargetInfo.
I think we can add Reload button to the component.

Regarding reloading the debuggee:
When we debug a tab, the target of toolbox that we can refer from DebugTargetInfo component is a front of BrowsingContextTargetActor.
And as the actor has reload function, we can reload using the function.

Regarding Back/Forward feature:
I had thought those functions are in BrowsingContextTargetActor, but it seems we don't have yet.
So, if we realize the feature, need to add and expose the functions in the actor and corresponding front.
(And check the backward compatibility)
So, it might be better to fix it in another bug.

Now, Micah is tackling to fix bug 1617237, but we can refer the code since modifying very similar place.
https://phabricator.services.mozilla.com/D70279
https://phabricator.services.mozilla.com/D70280
Hm, so, it might be better to fix this after bug 1617237 in order to avoid conflicts..

Flags: needinfo?(daisuke)
Attachment #9141333 - Attachment description: Bug 1617240 - Work in Progress - Add navigation buttons for remote debugging r=daisuke → Bug 1617240 - Add navigation buttons for remote debugging r=daisuke
Attachment #9141333 - Attachment description: Bug 1617240 - Add navigation buttons for remote debugging r=daisuke → Bug 1617240 - Work in Progress - Add navigation buttons for remote debugging r=daisuke
Attachment #9141333 - Attachment description: Bug 1617240 - Work in Progress - Add navigation buttons for remote debugging r=daisuke → Bug 1617240 - Add navigation buttons for remote debugging r=daisuke
Attachment #9141333 - Attachment description: Bug 1617240 - Add navigation buttons for remote debugging r=daisuke → Bug 1617240 - Work in Progress - Add navigation buttons for remote debugging r=daisuke
Attachment #9141333 - Attachment description: Bug 1617240 - Work in Progress - Add navigation buttons for remote debugging r=daisuke → Bug 1617240 - Add reload button for remote debugging r=daisuke
See Also: → 1637469
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94c64a721fdb
Add reload button for remote debugging r=daisuke,flod,victoria
Regressions: 1638472
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Blocks: 1635587
Regressions: 1641898
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: