1643990 - about:debugging's navigation button use alt attributes, localization comments says they are tooltips

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

about:debugging's navigation button use alt attributes, localization comments says they are tooltips. There are no tooltips shown.

 # LOCALIZATION NOTE (toolbox.debugTargetInfo.reload):
 # Used as the reload button tooltip
 toolbox.debugTargetInfo.reload=Reload
 
# LOCALIZATION NOTE (toolbox.debugTargetInfo.forward):
# Used as the navigation's "forward" button tooltip
toolbox.debugTargetInfo.forward=Forward

# LOCALIZATION NOTE (toolbox.debugTargetInfo.back):
# Used as the navigation's "back" button tooltip
toolbox.debugTargetInfo.back=Back

What were you doing?

1. Have Fenix Nightly on Android phone.
2. Have Firefox Nightly on desktop.
3. Press Alt key > Tools > Web developer > Remote debugging.
4. Enable USB debugging.
5. Connect phone to desktop using USB cable.
6. Turn on USB debugging on phone (please check your Android's documentation).
7. Refresh list of devices.
8. Connect from the remote debugging page to the phone.
9. Open Fenix on the phone.
10. Open a tab in it.
11. On the desktop, select the tab to debug.
12. Move mouse over navigation buttons.

What happened?

No tooltip.

What should have happened?

Tooltips mentioned above.

Currently, the strings are used as alt attributes of the image. To have them as tooltips, they shall be set as titles of the buttons.

If they aren't supposed to be tooltips: Please update the L10n comment.

Comment 1

[Julian Descottes [:jdescottes]]

I think the intent was to have them as tooltips? David can you confirm?

Comment 2

[David Walsh :davidwalsh]

Attachment: Bug 1643990 - Set tooltip for navigation buttons r=jdescottes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a1e6bfc8554
Set tooltip for navigation buttons r=flod,jdescottes

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7a1e6bfc8554