Closed Bug 1643990 Opened 8 months ago Closed 8 months ago

about:debugging's navigation button use alt attributes, localization comments says they are tooltips

Categories

(DevTools :: about:debugging, defect, P3)

defect

Tracking

(firefox79 fixed)

RESOLVED FIXED
Firefox 79
Tracking Status
firefox79 --- fixed

People

(Reporter: aryx, Assigned: davidwalsh)

References

(Regression)

Details

Attachments

(1 file)

about:debugging's navigation button use alt attributes, localization comments says they are tooltips. There are no tooltips shown.

 # LOCALIZATION NOTE (toolbox.debugTargetInfo.reload):
 # Used as the reload button tooltip
 toolbox.debugTargetInfo.reload=Reload
 
# LOCALIZATION NOTE (toolbox.debugTargetInfo.forward):
# Used as the navigation's "forward" button tooltip
toolbox.debugTargetInfo.forward=Forward

# LOCALIZATION NOTE (toolbox.debugTargetInfo.back):
# Used as the navigation's "back" button tooltip
toolbox.debugTargetInfo.back=Back

What were you doing?

  1. Have Fenix Nightly on Android phone.
  2. Have Firefox Nightly on desktop.
  3. Press Alt key > Tools > Web developer > Remote debugging.
  4. Enable USB debugging.
  5. Connect phone to desktop using USB cable.
  6. Turn on USB debugging on phone (please check your Android's documentation).
  7. Refresh list of devices.
  8. Connect from the remote debugging page to the phone.
  9. Open Fenix on the phone.
  10. Open a tab in it.
  11. On the desktop, select the tab to debug.
  12. Move mouse over navigation buttons.

What happened?

No tooltip.

What should have happened?

Tooltips mentioned above.

Currently, the strings are used as alt attributes of the image. To have them as tooltips, they shall be set as titles of the buttons.

If they aren't supposed to be tooltips: Please update the L10n comment.

I think the intent was to have them as tooltips? David can you confirm?

Severity: -- → S3
Flags: needinfo?(dwalsh)
Priority: -- → P3
Assignee: nobody → dwalsh
Status: NEW → ASSIGNED
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a1e6bfc8554
Set tooltip for navigation buttons r=flod,jdescottes
Flags: needinfo?(dwalsh)
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.