Move MutableScriptFlags into SharedStencil
Categories
(Core :: JavaScript Engine, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
Details
Attachments
(2 files)
(marking this as a regression, but really it's a reviewer error)
When I was helping land the first patch on Bug 1615729, I under-estimated the impact that the implicit conversion operators would have. Now that I've tried to extend code in the same area, by following a similar template for the MutableScriptFlags, I realize that there's definitely some friction.
The good news is that I think they're removable with fairly limited impact.
|
Assignee | |
Comment 1•4 years ago
|
||
I'm going to resummary this, if only because the nice way to do this is also to move MutableScriptFlags at the same time.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Have a partial patch for this, but want to clean it up a bit more (there's lovely symmetry that can be factored out when you also consider MutableFlags) but it's taking too long for this evening so will have to be Monday.
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D63941
|
||
Updated•4 years ago
|
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f6068403cbc7 Change implementation of SharedStencil ImmutableFlags to prepare for sharing r=caroline https://hg.mozilla.org/integration/autoland/rev/2ac78faa4373 Move MutableScriptFlags into SharedStencil r=caroline
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f6068403cbc7
https://hg.mozilla.org/mozilla-central/rev/2ac78faa4373
Description
•