1615729 - Can we make CompileOptions return us a JSScript::ImmutableFlags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

This will avoid having to copy all sorts of things individually and generally provide a route for us to share with Smoosh.

Comment 1

[Ted Campbell [:tcampbell]]

Probably worth sorting these flags to the start of the enum just for clarity. (Some of the ImmutableFlags are inputs, while the rest are only outputs).

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Should reorder these flags into:

[Input Flags]
[Parser Flags]
[Emitter Flags]

See CheckFlagsOnDelazification

Comment 3

[Caroline Cullen [:caroline]]

Attachment: Bug 1615729 - Move ImmutableFlags for SharedStencil.h. r=mgaudet

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3fffbd8245f
Move ImmutableFlags for SharedStencil.h. r=mgaudet

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/e3fffbd8245f

Comment 6

[Caroline Cullen [:caroline]]

Attachment: Bug 1615729 - Move setFlags with boolean logic into SharedStencil.h r=mgaudet

Comment 7

[Caroline Cullen [:caroline]]

Attachment: Bug 1615729 - Pass individual input flags as an ImmutableFlags to JSScript::Create. r=mgaudet

Depends on D64449

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edb67faa4068
Move setFlags with boolean logic into SharedStencil.h r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/dd11011dd49a
Pass individual input flags as an ImmutableFlags to JSScript::Create. r=mgaudet

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/edb67faa4068
https://hg.mozilla.org/mozilla-central/rev/dd11011dd49a

Comment 10

[Caroline Cullen [:caroline]]

Initially, we wanted to have CompileOptions contain a ImmutableScriptFlags, so instead of having 3 separate input flags within CompileOptions we would have one representation for all input flags and use that representation of those flags throughout the vm. In practice, this was a harder problem because CompileOptions lives within the js/public directory and SharedStencil within js/src/vm.

Comment 11

[Ted Campbell [:tcampbell]]

Even if we leave CompileOptions alone for the reasons you state, we should be able to remove uses of it from within the parser/bce themselves.

Comment 12

[Matthew Gaudet (he/him) [:mgaudet]]

We marked this one as leave-open because we split the landing: Can we resolve fixed now, or is there more patches incoming here?

Comment 13

[Caroline Cullen [:caroline]]

This patch as stated is fixed, the more robust solution is to come. Those patches will be attached to other bugs elsewhere in the tree.