1617332 - Intermittent browser/components/downloads/test/browser/browser_about_downloads.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:38 - TypeError: can't a

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: btara [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=289973531&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ddsa084kTeeJUMbGg9gdJA/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/ddsa084kTeeJUMbGg9gdJA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2020-02-21T23:01:12.955Z] 23:01:12     INFO - TEST-START | browser/components/downloads/test/browser/browser_about_downloads.js
[task 2020-02-21T23:01:13.372Z] 23:01:13     INFO - TEST-INFO | started process screenshot
[task 2020-02-21T23:01:13.437Z] 23:01:13     INFO - TEST-INFO | screenshot: exit 0
[task 2020-02-21T23:01:13.437Z] 23:01:13     INFO - Buffered messages logged at 23:01:12
[task 2020-02-21T23:01:13.437Z] 23:01:13     INFO - Entering test bound test_about_downloads
[task 2020-02-21T23:01:13.437Z] 23:01:13     INFO - Buffered messages logged at 23:01:13
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_about_downloads.js | Should have list of downloads - [object XULElement] == true - 
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_about_downloads.js | Should have 2 downloads. - 2 == 2 - 
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_about_downloads.js | Label 'dm-ui-test.file' should match 'dm-ui-test.file' - true == true - 
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - Buffered messages finished
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_about_downloads.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:38 - TypeError: can't access property "value", desc is null
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - Stack trace:
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - @chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:38:1
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:140:12
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1727:15
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:285:21
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - JSWindowActor query*receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1055:12
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - JSWindowActor query*spawn@resource://specialpowers/SpecialPowersChild.jsm:1682:17
[task 2020-02-21T23:01:13.438Z] 23:01:13     INFO - test_about_downloads/<@chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:28:25
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.jsm:150:24
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - async*test_about_downloads@chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:20:26
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:919:14
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:914:23
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - Leaving test bound test_about_downloads
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - Console message: [JavaScript Error: "Win error 2 during operation open on file C:\Users\task_1582324979\AppData\Local\Temp\dm-ui-test.file (The system cannot find the file specified.
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - )" {file: "resource://gre/modules/DownloadCore.jsm" line: 125}]
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - isPlaceholder@resource://gre/modules/DownloadCore.jsm:125:8
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - async*removeData@resource://gre/modules/DownloadCore.jsm:2383:16
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - removePartialData/this._promiseRemovePartialData<@resource://gre/modules/DownloadCore.jsm:879:28
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - removePartialData@resource://gre/modules/DownloadCore.jsm:889:9
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - finalize@resource://gre/modules/DownloadCore.jsm:1038:19
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - task_resetState@chrome://mochitests/content/browser/browser/components/downloads/test/browser/head.js:79:20
[task 2020-02-21T23:01:13.439Z] 23:01:13     INFO - async*nextTest@chrome://mochikit/content/browser-test.js:570:35
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - async*testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1457:25
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - run@chrome://mochikit/content/browser-test.js:1372:9
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - 
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - GECKO(4648) | MEMORY STAT | vsize 785MB | vsizeMaxContiguous 457MB | residentFast 254MB | heapAllocated 128MB
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - TEST-OK | browser/components/downloads/test/browser/browser_about_downloads.js | took 438ms
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_about_downloads.js | Found an unexpected tab at the end of test run: about:downloads - 
[task 2020-02-21T23:01:13.440Z] 23:01:13     INFO - checking window state
[task 2020-02-21T23:01:14.905Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 2248
[task 2020-02-21T23:01:14.905Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 1992
[task 2020-02-21T23:01:14.920Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 6076
[task 2020-02-21T23:01:14.940Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 4572
[task 2020-02-21T23:01:14.940Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 5284
[task 2020-02-21T23:01:14.947Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 4156
[task 2020-02-21T23:01:14.947Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 4740
[task 2020-02-21T23:01:14.954Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 1452
[task 2020-02-21T23:01:14.961Z] 23:01:14     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 1344
[task 2020-02-21T23:01:15.516Z] 23:01:15     INFO - GECKO(4648) | Completed ShutdownLeaks collections in process 3992
[task 2020-02-21T23:01:15.516Z] 23:01:15     INFO - TEST-START | Shutdown
...
...

Comment 1

[Intermittent Failures Robot]

2 failures in 4045 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 1

Platform breakdown:

• windows7-32: 1
• macosx1014-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617332&startday=2020-02-17&endday=2020-02-23&tree=all

Comment 2

[:Gijs (he/him)]

This is still happening so I'm puzzled... do the custom elements get initialized lazily or something? Marco, do you have some ideas?

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Seeing this on Tier 1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290174027&repo=autoland&lineNumber=3642

There are 2 failures: The one highlighted and " | Found an unexpected tab at the end of test run: about:downloads -"

[task 2020-02-24T12:06:13.033Z] 12:06:13     INFO - TEST-START | browser/components/downloads/test/browser/browser_about_downloads.js
[task 2020-02-24T12:06:13.572Z] 12:06:13     INFO - TEST-INFO | started process screencapture
[task 2020-02-24T12:06:13.735Z] 12:06:13     INFO - TEST-INFO | screencapture: exit 0
[task 2020-02-24T12:06:13.735Z] 12:06:13     INFO - Buffered messages logged at 12:06:12
[task 2020-02-24T12:06:13.736Z] 12:06:13     INFO - Entering test bound test_about_downloads
[task 2020-02-24T12:06:13.736Z] 12:06:13     INFO - Buffered messages logged at 12:06:13
[task 2020-02-24T12:06:13.736Z] 12:06:13     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_about_downloads.js | Should have list of downloads - [object XULElement] == true - 
[task 2020-02-24T12:06:13.736Z] 12:06:13     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_about_downloads.js | Should have 2 downloads. - 2 == 2 - 
[task 2020-02-24T12:06:13.736Z] 12:06:13     INFO - TEST-PASS | browser/components/downloads/test/browser/browser_about_downloads.js | Label 'dm-ui-test.file' should match 'dm-ui-test.file' - true == true - 
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - Buffered messages finished
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_about_downloads.js | Uncaught exception - at chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:38 - TypeError: can't access property "value", desc is null
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - Stack trace:
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - @chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:38:1
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - execute@resource://specialpowers/SpecialPowersSandbox.jsm:140:12
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - _spawnTask@resource://specialpowers/SpecialPowersChild.jsm:1727:15
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - receiveMessage@resource://specialpowers/SpecialPowersChild.jsm:285:21
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - JSWindowActor query*receiveMessage@resource://specialpowers/SpecialPowersParent.jsm:1055:12
[task 2020-02-24T12:06:13.737Z] 12:06:13     INFO - JSWindowActor query*spawn@resource://specialpowers/SpecialPowersChild.jsm:1682:17
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - test_about_downloads/<@chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:28:25
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.jsm:150:24
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - async*test_about_downloads@chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_about_downloads.js:20:26
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:914:23
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - Leaving test bound test_about_downloads
[task 2020-02-24T12:06:13.738Z] 12:06:13     INFO - Console message: [JavaScript Error: "Unix error 2 during operation stat on file /var/folders/s8/_j7pk_d55kq9pc67fqqt282c000017/T/dm-ui-test.file (No such file or directory)" {file: "resource://gre/modules/DownloadCore.jsm" line: 125}]
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - isPlaceholder@resource://gre/modules/DownloadCore.jsm:125:8
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - async*removeData@resource://gre/modules/DownloadCore.jsm:2383:16
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - removePartialData/this._promiseRemovePartialData<@resource://gre/modules/DownloadCore.jsm:879:28
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - removePartialData@resource://gre/modules/DownloadCore.jsm:889:9
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - finalize@resource://gre/modules/DownloadCore.jsm:1038:19
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - task_resetState@chrome://mochitests/content/browser/browser/components/downloads/test/browser/head.js:79:20
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - async*nextTest@chrome://mochikit/content/browser-test.js:570:35
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - async*testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1457:25
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - run@chrome://mochikit/content/browser-test.js:1372:9
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - 
[task 2020-02-24T12:06:13.739Z] 12:06:13     INFO - GECKO(1972) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2020-02-24T12:06:13.740Z] 12:06:13     INFO - GECKO(1972) | MEMORY STAT | vsize 6980MB | residentFast 331MB | heapAllocated 135MB
[task 2020-02-24T12:06:13.740Z] 12:06:13     INFO - TEST-OK | browser/components/downloads/test/browser/browser_about_downloads.js | took 599ms
[task 2020-02-24T12:06:13.748Z] 12:06:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-02-24T12:06:13.748Z] 12:06:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_about_downloads.js | Found an unexpected tab at the end of test run: about:downloads - 
[task 2020-02-24T12:06:13.748Z] 12:06:13     INFO - checking window state
[task 2020-02-24T12:06:13.748Z] 12:06:13     INFO - TEST-START | browser/components/downloads/test/browser/browser_basic_functionality.js
[task 2020-02-24T12:06:14.030Z] 12:06:14     INFO - GECKO(1972) | MEMORY STAT | vsize 6986MB | residentFast 327MB | heapAllocated 130MB
[task 2020-02-24T12:06:14.031Z] 12:06:14     INFO - TEST-OK | browser/components/downloads/test/browser/browser_basic_functionality.js | took 332ms

Comment 4

[Marco Bonardo [:mak]]

hmm, the only thing I found is this timer
https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/browser/components/downloads/content/allDownloadsView.js#264
that I added years ago in bug 827405 to ensure scrolling wasn't overhandling events... Having a second look at that, the timer should have been added only for the the onScroll and resize events that can fire often and should not completely kill the ui while that happens.
Removing that timer in the other cases may help you here, that requires a little bit of recfactoring to split the 2 cases (update on a timer, or update immediately).

Comment 5

[Intermittent Failures Robot]

22 failures in 5233 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 21
• try: 1

Platform breakdown:

• macosx1014-64-shippable: 21
• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617332&startday=2020-02-24&endday=2020-03-01&tree=all

Comment 6

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bb0ade60dabb4a2b2426b2a0b5942bd86cf7c26

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1617332 - activate downloads view elements immediately instead of debouncing all the time, r?mak

Comment 8

[Intermittent Failures Robot]

15 failures in 1032 pushes (0.015 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• mozilla-central: 1
• try: 1

Platform breakdown:

• macosx1014-64-shippable: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617332&startday=2020-03-04&endday=2020-03-04&tree=all

Comment 9

[Intermittent Failures Robot]

39 failures in 5483 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

This is the #27 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 33
• mozilla-central: 3
• try: 3

Platform breakdown:

• macosx1014-64-shippable: 37
• macosx1014-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617332&startday=2020-03-02&endday=2020-03-08&tree=all

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d8b346540db
activate downloads view elements immediately instead of debouncing all the time, r=mak

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/7d8b346540db

Comment 12

[:Gijs (he/him)]

Comment on attachment 9130881 [details]
Bug 1617332 - activate downloads view elements immediately instead of debouncing all the time, r?mak

Beta/Release Uplift Approval Request

• User impact if declined: intermittent test failures; problems with focusing items in the download list ( bug 1549687 and friends)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small changes in how we handle creating content in views that list all downloads.
• String changes made/needed: nope

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9130881 [details]
Bug 1617332 - activate downloads view elements immediately instead of debouncing all the time, r?mak

approved for 75.0b2

Comment 14

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ddf69eb9fd74

Comment 15

[Intermittent Failures Robot]

1 failures in 5336 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• macosx1014-64-devedition: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617332&startday=2020-03-09&endday=2020-03-15&tree=all