[rust] Reformat the tree using rustfmt
Categories
(Firefox Build System :: Lint and Formatting, task, P2)
Tracking
(Not tracked)
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: leave-open)
Attachments
(44 files, 5 obsolete files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
mach lint -l rustfmt --fix works well, it is enabled at review phase and we have tests in the CI. Let's see how to do it!
The patch is only 1.4M. As comparison, the move to the Google Coding style was 177M
| Assignee | ||
Comment 1•1 year ago
|
||
Reformatting the whole tree takes less than ~15s
| Assignee | ||
Comment 2•1 year ago
|
||
| Assignee | ||
Comment 3•1 year ago
|
||
ignore-this-changeset
Depends on D63758
| Assignee | ||
Comment 4•1 year ago
|
||
| Assignee | ||
Comment 5•1 year ago
|
||
| Assignee | ||
Comment 6•1 year ago
|
||
Depends on D63952
| Assignee | ||
Comment 7•1 year ago
|
||
Depends on D63955
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c624c72bb30f Reformat toolkit/crashreporter/ & toolkit/library/rust/ using rustfmt r=gsvelto
| Assignee | ||
Updated•1 year ago
|
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f243a9acd63f Reformat testing/ using rustfmt r=whimboo,webdriver-reviewers
Comment 10•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/902bbf296882 Reformat xpcom using rustfmt r=froydnj
Comment 11•1 year ago
|
||
| bugherder | ||
Comment 12•1 year ago
|
||
| bugherder | ||
Comment 13•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93f12592ed0a Reformat js/ using rustfmt r=arai,bbouvier
| Assignee | ||
Comment 14•1 year ago
|
||
Updated audioipc directly upstream:
https://github.com/djg/audioipc-2/pull/91/commits/b1497b9c7d39b49bd85ed5cb751d93b0935e633c
Updated•1 year ago
|
Comment 15•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 16•1 year ago
|
||
| Assignee | ||
Comment 17•1 year ago
|
||
Depends on D64869
| Assignee | ||
Comment 18•1 year ago
|
||
Depends on D64870
| Assignee | ||
Comment 19•1 year ago
|
||
Depends on D64871
| Assignee | ||
Comment 20•1 year ago
|
||
Depends on D64873
| Assignee | ||
Comment 21•1 year ago
|
||
Depends on D64874
| Assignee | ||
Comment 22•1 year ago
|
||
Depends on D64875
Comment 23•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/810e31bf46f1 Reformat kvstore using rustfmt r=vporof
| Assignee | ||
Comment 24•1 year ago
|
||
Depends on D64875
Comment 25•1 year ago
|
||
| bugherder | ||
Comment 26•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f4da392a2fa Reformat libpref/ using rustfmt r=njn https://hg.mozilla.org/integration/autoland/rev/30451b2d1793 Rename C_HASH & C_CR to have the same length r=njn
Comment 27•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59d60966212e Reformat testing/ using rustfmt r=valentin
Updated•1 year ago
|
Comment 28•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eadd6558fe3 Reformat bitsdownload/ using rustfmt r=valentin
Comment 29•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57557b6c13d5 Reformat storage/variant/ using rustfmt r=lina
Comment 30•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d5155142c8a0 Reformat tools/profiler/rust-helper/ using rustfmt r=mstange
Comment 31•1 year ago
|
||
| bugherder | ||
Comment 32•1 year ago
|
||
| bugherder | ||
Comment 33•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/44221eabe5aa Reformat intl/ using rustfmt r=zbraniecki,hsivonen
Comment 34•1 year ago
|
||
| bugherder | ||
Comment 35•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ba1101a88a1f Reformat mozglue/ using rustfmt r=glandium
Comment 36•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 37•1 year ago
|
||
| Assignee | ||
Comment 38•1 year ago
|
||
Depends on D65897
| Assignee | ||
Comment 39•1 year ago
|
||
Depends on D65901
| Assignee | ||
Comment 40•1 year ago
|
||
Depends on D65902
Comment 41•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77be1b7956df Reformat netwerk/ using rustfmt r=agrover
Comment 42•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/337b6019e3d4 Reformat rsdparsa_capi/ using rustfmt r=dminor
Comment 43•1 year ago
|
||
| bugherder | ||
Comment 44•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1695699198d4 Reformat webrender_bindings/ using rustfmt r=nical https://hg.mozilla.org/integration/autoland/rev/f08d49f7adf0 Reformat a rust test using rustfmt r=marco
Comment 45•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
| Assignee | ||
Comment 46•1 year ago
|
||
Comment 47•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcde24b872ed Reformat recent rust changes r=webdriver-reviewers,whimboo
Comment 48•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
| Assignee | ||
Comment 49•1 year ago
|
||
| Assignee | ||
Comment 50•1 year ago
|
||
Comment 51•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed8741d48e2a Reformat intl/l10n/rust/fluent-ffi/ using rustfmt r=zbraniecki
Comment 52•1 year ago
|
||
| bugherder | ||
Comment 53•1 year ago
|
||
uses the default config with rustfmt-stable
Comment 54•1 year ago
|
||
Pushed by dmalyshau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05790c733415 Rustfmt pass over gfx/wgpu r=sylvestre
Comment 55•1 year ago
|
||
| bugherder | ||
Updated•1 year ago
|
| Assignee | ||
Comment 56•1 year ago
|
||
Done with:
./mach lint -l rustfmt --fix
with
rustfmt 1.4.12-stable (a828ffe 2020-03-11)
ignore-this-changeset
Updated•1 year ago
|
Comment 57•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08a0e1e4864c Reformat recent rust changes with rustfmt r=emilio
Comment 58•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 59•1 year ago
|
||
Comment 60•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a8437dd2b85 Reformat recent rust changes with rustfmt r=emilio
Comment 61•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 62•1 year ago
|
||
Updated•1 year ago
|
Comment 63•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b6a16bd94fe Reformat recent rust changes with rustfmt r=kvark DONTBUILD
Comment 64•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 65•1 year ago
|
||
ignore-this-changeset
Depends on D76451
Updated•1 year ago
|
Comment 66•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/171e43a075c2 Reformat recent rust changes with rustfmt r=emilio DONTBUILD
Comment 67•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 68•1 year ago
|
||
# ignore-this-changeset
Depends on D76451
Comment 69•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2221f584b0f Reformat recent rust changes with rustfmt r=webdriver-reviewers,whimboo
Comment 70•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 71•1 year ago
|
||
ignore-this-changeset
Depends on D77580
Comment 72•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6eedccd860c3 Reformat recent rust changes with rustfmt r=froydnj
Comment 73•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 74•1 year ago
|
||
ignore-this-changeset
Comment 75•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/63ce2e510b00 Reformat recent rust changes with rustfmt r=arai
Comment 76•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 77•1 year ago
|
||
ignore-this-changeset
Depends on D79795
Comment 78•1 year ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa0afb432810 Reformat recent rust changes with rustfmt r=emilio
Comment 79•1 year ago
|
||
| bugherder | ||
| Assignee | ||
Comment 80•11 months ago
|
||
# ignore-this-changeset
Depends on D83258
Comment 81•11 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b234115ff57e Reformat recent rust changes with rustfmt r=emilio
Comment 82•11 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 83•10 months ago
|
||
ignore-this-changeset
Depends on D85678
Comment 84•10 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dfcab23e3c1 Reformat recent rust changes with rustfmt r=emilio
Comment 85•10 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 86•9 months ago
|
||
ignore-this-changeset
Depends on D88713
Comment 87•9 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c5a72376017 Reformat recent rust changes with rustfmt r=emilio
Comment 88•9 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 89•9 months ago
|
||
ignore-this-changeset
Depends on D89392
Comment 90•9 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90bf9d8e0b52 Reformat recent rust changes with rustfmt r=emilio
Comment 91•9 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 92•8 months ago
|
||
ignore-this-changeset
Depends on D90793
Comment 93•8 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc4d17795322 Reformat recent rust changes with rustfmt r=emilio,necko-reviewers,valentin
Comment 94•8 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 95•8 months ago
|
||
ignore-this-changeset
Depends on D92459
Comment 96•8 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1449020ffc52 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,necko-reviewers,dragana,whimboo
Comment 97•8 months ago
|
||
| bugherder | ||
Comment 98•7 months ago
|
||
Sylvestre, is there anything left to do here, or can the bug get closed?
| Assignee | ||
Comment 99•7 months ago
|
||
Yeah, I am regularly refreshing the tree as it regresses.
So, keeping it until we have a better solution to update the tree.
| Assignee | ||
Comment 100•7 months ago
|
||
# ignore-this-changeset
Depends on D95434
Comment 101•7 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b76268bfeb60 Reformat recent rust changes with rustfmt r=emilio,necko-reviewers
Comment 102•7 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 103•7 months ago
|
||
ignore-this-changeset
Depends on D96608
Comment 104•7 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fa9c10eefd0 Reformat recent rust changes with rustfmt r=emilio
Comment 105•7 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 106•7 months ago
|
||
Updated•7 months ago
|
| Assignee | ||
Comment 107•6 months ago
|
||
ignore-this-changeset
Depends on D90795
Comment 108•6 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b79688522892 Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,jgraham
Comment 109•6 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 110•6 months ago
|
||
ignore-this-changeset
Depends on D98301
Comment 111•6 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6aa458d78985 Reformat recent rust changes with rustfmt r=emilio DONTBUILD
Comment 112•6 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 113•5 months ago
|
||
Updated with rustfmt 1.4.24-stable (eb894d5 2020-11-05)
ignore-this-changeset
Depends on D100230
Comment 114•5 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32c9a04e95db Reformat recent rust changes with rustfmt r=emilio DONTBUILD
Comment 115•5 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 116•5 months ago
|
||
Updated with rustfmt 1.4.25-stable (0f29ff6 2020-11-11)
ignore-this-changeset
Depends on D100934
Comment 117•5 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/974cf1a79377 Reformat recent rust changes with rustfmt r=emilio
Comment 118•5 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 119•4 months ago
|
||
Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)
ignore-this-changeset
Depends on D105158
Comment 120•4 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea2cfbe4a0f4 Reformat recent rust changes with rustfmt r=emilio DONTBUILD
Comment 121•4 months ago
|
||
| bugherder | ||
| Assignee | ||
Comment 122•3 months ago
|
||
Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)
ignore-this-changeset
Depends on D106920
Comment 123•3 months ago
|
||
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7633e66d8199 Reformat recent rust changes with rustfmt r=emilio
Comment 124•3 months ago
|
||
| bugherder | ||
Comment 125•1 month ago
|
||
Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)
# ignore-this-changeset
Depends on D113294
Updated•1 month ago
|
Comment 126•1 month ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72a8fb6cee5a Reformat recent rust changes with rustfmt. r=webdriver-reviewers,kvark
Comment 127•1 month ago
|
||
| bugherder | ||
Comment 128•26 days ago
|
||
Initial reformat with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D114211
Comment 129•24 days ago
|
||
Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D114211
Updated•24 days ago
|
Comment 130•21 days ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eaeaa4460a8d Reformat recent rust changes with rustfmt r=emilio,sylvestre
Comment 131•21 days ago
|
||
| bugherder | ||
Comment 132•7 days ago
|
||
Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)
Depends on D115804
Comment 133•7 days ago
|
||
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/507717b6ecb0 Reformat recent rust changes with rustfmt r=emilio
Comment 134•7 days ago
|
||
| bugherder | ||
Description
•