Open Bug 1617369 Opened 1 year ago Updated 7 days ago

[rust] Reformat the tree using rustfmt

Categories

(Firefox Build System :: Lint and Formatting, task, P2)

task

Tracking

(Not tracked)

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(44 files, 5 obsolete files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

mach lint -l rustfmt --fix works well, it is enabled at review phase and we have tests in the CI. Let's see how to do it!

The patch is only 1.4M. As comparison, the move to the Google Coding style was 177M

Reformatting the whole tree takes less than ~15s

ignore-this-changeset

Depends on D63758

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c624c72bb30f
Reformat toolkit/crashreporter/ & toolkit/library/rust/ using rustfmt r=gsvelto
Keywords: leave-open
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f243a9acd63f
Reformat testing/ using rustfmt r=whimboo,webdriver-reviewers
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/902bbf296882
Reformat xpcom using rustfmt r=froydnj
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93f12592ed0a
Reformat js/ using rustfmt r=arai,bbouvier
Priority: -- → P2
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/810e31bf46f1
Reformat kvstore using rustfmt r=vporof
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4f4da392a2fa
Reformat libpref/ using rustfmt r=njn
https://hg.mozilla.org/integration/autoland/rev/30451b2d1793
Rename C_HASH & C_CR to have the same length r=njn
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59d60966212e
Reformat testing/ using rustfmt r=valentin
Attachment #9129970 - Attachment description: Bug 1617369 - Reformat storage/variant/ using rustfmt r?nija → Bug 1617369 - Reformat storage/variant/ using rustfmt r?nika
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eadd6558fe3
Reformat bitsdownload/ using rustfmt r=valentin
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57557b6c13d5
Reformat storage/variant/ using rustfmt r=lina
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5155142c8a0
Reformat tools/profiler/rust-helper/ using rustfmt r=mstange
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44221eabe5aa
Reformat intl/ using rustfmt r=zbraniecki,hsivonen
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba1101a88a1f
Reformat mozglue/ using rustfmt r=glandium
Blocks: rustfmt
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77be1b7956df
Reformat netwerk/ using rustfmt r=agrover
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/337b6019e3d4
Reformat rsdparsa_capi/ using rustfmt r=dminor
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1695699198d4
Reformat webrender_bindings/ using rustfmt r=nical
https://hg.mozilla.org/integration/autoland/rev/f08d49f7adf0
Reformat a rust test using rustfmt r=marco
Attachment #9128314 - Attachment is obsolete: true
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcde24b872ed
Reformat recent rust changes r=webdriver-reviewers,whimboo
Attachment #9128315 - Attachment is obsolete: true
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ed8741d48e2a
Reformat intl/l10n/rust/fluent-ffi/ using rustfmt r=zbraniecki

uses the default config with rustfmt-stable

Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/05790c733415
Rustfmt pass over gfx/wgpu r=sylvestre
Attachment #9135372 - Attachment is obsolete: true

Done with:
./mach lint -l rustfmt --fix
with
rustfmt 1.4.12-stable (a828ffe 2020-03-11)

ignore-this-changeset

Depends on: 1633130
Attachment #9143348 - Attachment description: Bug 1617369 - Reformat recent rust changes with rustfmt r?bholley → Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08a0e1e4864c
Reformat recent rust changes with rustfmt r=emilio
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a8437dd2b85
Reformat recent rust changes with rustfmt r=emilio
Attachment #9148264 - Attachment description: Bug 1617369 - Reformat recent rust changes with rustfmt r?kvark → Bug 1617369 - Reformat recent rust changes with rustfmt r?kvark DONTBUILD
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b6a16bd94fe
Reformat recent rust changes with rustfmt r=kvark DONTBUILD

ignore-this-changeset

Depends on D76451

Attachment #9150990 - Attachment description: Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio → Bug 1617369 - Reformat recent rust changes with rustfmt r?emilio DONTBUILD
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/171e43a075c2
Reformat recent rust changes with rustfmt r=emilio DONTBUILD

# ignore-this-changeset

Depends on D76451

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2221f584b0f
Reformat recent rust changes with rustfmt r=webdriver-reviewers,whimboo

ignore-this-changeset

Depends on D77580

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6eedccd860c3
Reformat recent rust changes with rustfmt r=froydnj
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63ce2e510b00
Reformat recent rust changes with rustfmt r=arai

ignore-this-changeset

Depends on D79795

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa0afb432810
Reformat recent rust changes with rustfmt r=emilio

# ignore-this-changeset

Depends on D83258

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b234115ff57e
Reformat recent rust changes with rustfmt r=emilio
Blocks: 1655669

ignore-this-changeset

Depends on D85678

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dfcab23e3c1
Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D88713

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c5a72376017
Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D89392

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90bf9d8e0b52
Reformat recent rust changes with rustfmt r=emilio

ignore-this-changeset

Depends on D90793

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc4d17795322
Reformat recent rust changes with rustfmt r=emilio,necko-reviewers,valentin

ignore-this-changeset

Depends on D92459

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1449020ffc52
Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,necko-reviewers,dragana,whimboo

Sylvestre, is there anything left to do here, or can the bug get closed?

Flags: needinfo?(sledru)

Yeah, I am regularly refreshing the tree as it regresses.
So, keeping it until we have a better solution to update the tree.

Flags: needinfo?(sledru)

# ignore-this-changeset

Depends on D95434

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b76268bfeb60
Reformat recent rust changes with rustfmt r=emilio,necko-reviewers

ignore-this-changeset

Depends on D96608

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8fa9c10eefd0
Reformat recent rust changes with rustfmt r=emilio
Attachment #9188282 - Attachment is obsolete: true

ignore-this-changeset

Depends on D90795

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b79688522892
Reformat recent rust changes with rustfmt r=emilio,webdriver-reviewers,jgraham

ignore-this-changeset

Depends on D98301

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6aa458d78985
Reformat recent rust changes with rustfmt r=emilio DONTBUILD

Updated with rustfmt 1.4.24-stable (eb894d5 2020-11-05)

ignore-this-changeset

Depends on D100230

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32c9a04e95db
Reformat recent rust changes with rustfmt r=emilio DONTBUILD

Updated with rustfmt 1.4.25-stable (0f29ff6 2020-11-11)

ignore-this-changeset

Depends on D100934

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/974cf1a79377
Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)

ignore-this-changeset

Depends on D105158

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea2cfbe4a0f4
Reformat recent rust changes with rustfmt r=emilio DONTBUILD

Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)

ignore-this-changeset

Depends on D106920

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7633e66d8199
Reformat recent rust changes with rustfmt r=emilio

Updated with rustfmt 1.4.18-stable (8157a3f 2020-07-15)

# ignore-this-changeset

Depends on D113294

Attachment #9218259 - Attachment description: WIP: Bug 1617369 - Reformat recent rust changes with rustfmt. → Bug 1617369 - Reformat recent rust changes with rustfmt.
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72a8fb6cee5a
Reformat recent rust changes with rustfmt. r=webdriver-reviewers,kvark

Initial reformat with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D114211

Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D114211

Attachment #9220838 - Attachment is obsolete: true
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eaeaa4460a8d
Reformat recent rust changes with rustfmt r=emilio,sylvestre

Updated with rustfmt 1.4.36-stable (7de6968 2021-02-07)

Depends on D115804

Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/507717b6ecb0
Reformat recent rust changes with rustfmt r=emilio
You need to log in before you can comment on or make changes to this bug.