Closed
Bug 1633130
Opened 5 years ago
Closed 5 years ago
mach lint -l rustfmt should verify the rustfmt version
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox78 fixed)
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: undef1nd, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=rust][lang=python])
Attachments
(1 file)
Just like clang-format, rustfmt evolves and the output can change.
We have a check to verify that we aren't using a deprecated version of rustfmt already:
https://searchfox.org/mozilla-central/source/tools/lint/rust/__init__.py#110
And, maybe, the expected version should be declared here:
https://searchfox.org/mozilla-central/source/tools/lint/rustfmt.yml
We should probably use the version shipping in rustup:
rustfmt 1.4.12-stable (a828ffe 2020-03-11)
The list of versions is available here: https://github.com/rust-lang/rustfmt/releases
We already have a check for rust itself:
https://searchfox.org/mozilla-central/source/build/moz.configure/rust.configure#151
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → yalyna.ts
Status: NEW → ASSIGNED
|
|
||
Updated•5 years ago
|
Attachment #9143723 -
Attachment description: Bug 1633130 - Add version for rustfmt lint,r=sylvestre → Bug 1633130 - Add expected version for rustfmt lint,r=sylvestre
|
|
||
Updated•5 years ago
|
Attachment #9143723 -
Attachment description: Bug 1633130 - Add expected version for rustfmt lint,r=sylvestre → Bug 1633130 - Add version for rustfmt lint,r=sylvestre
|
|
||
Updated•5 years ago
|
Attachment #9143723 -
Attachment description: Bug 1633130 - Add version for rustfmt lint,r=sylvestre → Bug 1633130 - Add expected version for rustfmt lint,r=sylvestre
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca6bc5ff4e71
Add expected version for rustfmt lint,r=sylvestre
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•