1617437 - Fails to build with [-Werror,-Wnon-c-typedef-for-linkage]

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Introduced in clang-11 (trunk currently)
https://reviews.llvm.org/D74103

In file included from /var/lib/jenkins/workspace/firefox-clang-lld-last/js/src/gc/StoreBuffer.cpp:7:
In file included from /var/lib/jenkins/workspace/firefox-clang-lld-last/js/src/gc/StoreBuffer-inl.h:10:
/var/lib/jenkins/workspace/firefox-clang-lld-last/js/src/gc/StoreBuffer.h:372:19: error: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]
    typedef struct {
                  ^
                   Hasher
/var/lib/jenkins/workspace/firefox-clang-lld-last/js/src/gc/StoreBuffer.h:373:7: note: type is not C-compatible due to this member declaration
      typedef SlotsEdge Lookup;
      ^~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/firefox-clang-lld-last/js/src/gc/StoreBuffer.h:378:7: note: type is given name 'Hasher' for linkage purposes by this typedef declaration
    } Hasher;
      ^

 4:13.01 In file included from /var/lib/jenkins/workspace/firefox-clang-lld-last/xpcom/tests/gtest/TestTaskQueue.cpp:9:
 4:13.01 /var/lib/jenkins/workspace/firefox-clang-lld-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/TaskQueue.h:131:17: error: anonymous non-C-compatible type given name for linkage purposes by typedef declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]
 4:13.01   typedef struct {
 4:13.01                 ^
 4:13.01                  TaskStruct
 4:13.01 /var/lib/jenkins/workspace/firefox-clang-lld-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/TaskQueue.h:131:11: note: type is not C-compatible due to this member declaration
 4:13.01   typedef struct {
 4:13.01           ^~~~~~
 4:13.01 /var/lib/jenkins/workspace/firefox-clang-lld-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/TaskQueue.h:134:5: note: type is given name 'TaskStruct' for linkage purposes by this typedef declaration
 4:13.01   } TaskStruct;
 4:13.01     ^

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1617437 - StoreBuffer.h: Fix a -Wnon-c-typedef-for-linkage warning r?jandem

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1617437 - TaskQueue.h: Fix a -Wnon-c-typedef-for-linkage warning r?froydnj

Depends on D63781

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1617437 - gfxFontUtils.cpp: Fix two -Wnon-c-typedef-for-linkage warnings r?jfkthame

Depends on D63783

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1617437 - OggCodecState.h/DynamicsCompressor.h: Fix two -Wnon-c-typedef-for-linkage warnings r=jya

Depends on D63784

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1617437 - ssltunnel.cpp: Fix some -Wnon-c-typedef-for-linkage warnings r=keeler

Depends on D63785

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4e30e9317ad
gfxFontUtils.cpp: Fix two -Wnon-c-typedef-for-linkage warnings r=jfkthame

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5d2d89c4f92
TaskQueue.h: Fix a -Wnon-c-typedef-for-linkage warning r=froydnj

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b4e30e9317ad
https://hg.mozilla.org/mozilla-central/rev/f5d2d89c4f92

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9002e61db7d
StoreBuffer.h: Fix a -Wnon-c-typedef-for-linkage warning r=jandem

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e9002e61db7d

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7ff41aba0ec
ssltunnel.cpp: Fix some -Wnon-c-typedef-for-linkage warnings r=keeler

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f7ff41aba0ec

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31b56def2a8d
OggCodecState.h/DynamicsCompressor.h: Fix two -Wnon-c-typedef-for-linkage warnings r=jya

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/31b56def2a8d

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

I think we fixed every items