Closed Bug 1617451 Opened 1 year ago Closed 1 year ago

Port bug 1547718: Remove preferenceBindings.js from eval()-whitelist

Categories

(Thunderbird :: Preferences, task)

Product:
Thunderbird
Component:
Preferences
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 75.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

1617451-eval-remove-preferenceBindings.patch
7.99 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review

Adding and changing in the Language dialog works but when I close the dialog with "OK" nothing happens. Re-opening the dialog shows the previous state.

Bug 1547718 removed the onbeforeaccept attribute (and others we don't use).

We used this only in two dialogs.

Port of https://hg.mozilla.org/mozilla-central/rev/d426669c4cba

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9128376 - Flags: review?(mkmelin+mozilla)
Type: defect → task
Attachment #9128376 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 75.0

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/560479c08fef
Port bug 1547718: Remove preferenceBindings.js from eval()-whitelist. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.