Closed
Bug 1617452
Opened 5 years ago
Closed 5 years ago
Move the type="child" to <window> instead of <dialog>
Categories
(Thunderbird :: Preferences, task)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 75.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file)
|
11.59 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
We have the type="child" in <dialog> but m-c has them in <window>. See https://searchfox.org/mozilla-central/search?q=type%3D%22child%22&case=false®exp=false&path=
|
Assignee | |
Comment 1•5 years ago
|
||
Moved the type="child" from <dialog> to <window>. Also removed the not used class="prefwindow" and role="dialog" in the preferences in-content dialogs.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9128379 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9128379 [details] [diff] [review]
1617452-move-type-child.patch
Review of attachment 9128379 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thx! r=mkmelin
Attachment #9128379 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 75.0
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/127448808475
Move the type="child" to <window> instead of <dialog>. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•