Closed Bug 1617452 Opened 1 year ago Closed 1 year ago

Move the type="child" to <window> instead of <dialog>

Categories

(Thunderbird :: Preferences, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 75.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

We have the type="child" in <dialog> but m-c has them in <window>. See https://searchfox.org/mozilla-central/search?q=type%3D%22child%22&case=false&regexp=false&path=

Moved the type="child" from <dialog> to <window>. Also removed the not used class="prefwindow" and role="dialog" in the preferences in-content dialogs.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9128379 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9128379 [details] [diff] [review]
1617452-move-type-child.patch

Review of attachment 9128379 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #9128379 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 75.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/127448808475
Move the type="child" to <window> instead of <dialog>. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.