Closed Bug 1617535 Opened 1 year ago Closed 1 year ago

Intermittent comm/mail/test/browser/addrbook/browser_addressBook.js | Uncaught exception - at resource://testing-common/mozmill/AddressBookHelpers.jsm:260 - Error: Could not find the index for the address book named Some Mailing List

Categories

(Thunderbird :: Address Book, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 75.0

People

(Reporter: intermittent-bug-filer, Assigned: darktrojan)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

There's some weird timing issue going on. I haven't got to the bottom of it yet.

Assignee: nobody → geoff
Status: NEW → ASSIGNED

I don't know for sure that this fixes the test, but I think it does. There seems to be something going on relating to when the new address book dialog shows. I can get differing results by waiting for different lengths of time at various points, and also if I run the whole directory versus just the test.

I've also changed both tests in this directory to wait for address book deletion before ending.

Attachment #9128674 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9128674 [details] [diff] [review]
1617535-addrbook-timing-1.diff

Review of attachment 9128674 [details] [diff] [review]:
-----------------------------------------------------------------

Let's try it.
Attachment #9128674 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → Thunderbird 75.0

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/56ae836a9049
Attempt to fix timing issues in address book tests. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

Oh, um, that wasn't even a fix for the right test failure.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Calling this fixed by bug 1618100.

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → WORKSFORME

Oh, I landed something, I guess it should be FIXED not WORKSFORME.

Resolution: WORKSFORME → FIXED
You need to log in before you can comment on or make changes to this bug.