16176 - [DOGFOOD] need to annotate line frames with whitespace trimming info

Status: VERIFIED FIXED

(Core :: Layout, defect, P1)

Description

[buster]

To solve the problem on imaging a space at the end of a line in the editor (that
is, imaging the caret offset from the last character in a line when the last
character is a space), we need the line frame to be annotated with the result of
the whitespace trimming code.  Given that, the caret can be taught how to paint
itself to show the space.


Marked dogfood because this is required to fix a dogfood caret imaging bug
14573


Kipp, please assign back to me when your part is done.

Comment 1

[buster]

kipp claims this is trivial, so asking for M11.

Comment 2

[kipp]

Fix is in my tree; waiting for a code review

Comment 3

[kipp]

Code's in; nsILineIterator's GetLine method now returns "flags" for each line;
see the definitions at the top...

Comment 4

[leger]

Putting on the [PDT+] radar.

Comment 5

[buster]

assigned to sfraser, cc kin.  Could one of you look at this as a high priority
dogfood item?  I hear lots of complaints about the editor not handling spaces
correctly, and it makes for some awkward editing without the visual feedback of
a space at the end of the line.

Comment 6

[kinmoz]

Assigning to [e-mail].

Comment 7

[kinmoz]

Accepting bug.

Comment 8

[kinmoz]

Changed QA contact from [e-mail] to [e-mail] per
[e-mail].

Comment 9

[kinmoz]

Fix checked in to Mozilla 5.0 tip. This fix actually went a different route,
instead of using the line iterator's line flags, I modified
nsTextFrame::nsGetPointFromOffset() to check mFlags and tack on the width of the
missing space if it was trimmed.

    layout/base/src/nsCaret.cpp    revision 1.36
        - Modified DrawCaretWithContext so that we only
          adjust the caret position if we are within the
          frame's bounds.

    layout/html/base/src/nsTextFrame.cpp    revision 1.189
        - Modified GetPointFromOffset() to add the width
          of a space if the offset is after a trailing space
          and it was trimmed off the frame.

Fix was reviewed by [e-mail].

Comment 10

[sujay]

re-assigning to petersen.

Comment 11

[Chris Petersen]

Steve, I'm not sure what I should do to verify this fix. Is there a test case I

could use to help me ?

Comment 12

[kinmoz]

Testing for this is easy.

Startup a blank composer, then type a word and hit the space bar. The caret
should advance by a space.

Before this bug was fixed, the caret would not advance till you hit the space
bar twice to enter 2 spaces.

Comment 13

[Chris Petersen]

With the Dec 01 build (1999120108), this problem has been fixed.