Closed Bug 14573 Opened 25 years ago Closed 25 years ago

[dogfood] Must press Space twice to insert space in Editor window

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: cpratt, Assigned: kinmoz)

References

Details

(Whiteboard: [PDT+]) 

Build ID: 1999092208
Platform: Windows NT (US-International keyboard layout)

To reproduce:
- Launch apprunner
- Select File | New | New Blank Window
- In the new Editor window that is generated, try typing anything

Result: Every time you want to type a space, you must press the spacebar
*twice*.

Expected result: One press of the spacebar should generate a space.
Assignee: buster → jfrancis
Priority: P3 → P2
Target Milestone: M12
I don't see this, maybe my fix to isEditable (not yet checked in) corrected this
problem?
assigned to joe.
Status: NEW → ASSIGNED
accepting bug / m12
buster, I did not describe the problem accurately enough. When you press the
spacebar, a space actually *is* generated, but it is not reflected visually on
the screen. That is, if you type "hello^world" (the caret represents the space)
you see "hello world" on the screen - but if you just type "hello^" you will see
"hello|" where | represents the caret instead of "hello |".
*** Bug 15289 has been marked as a duplicate of this bug. ***
From Kin's bug:

"There seems to be some optimization in layout that does not extend the text

frame's width for a trailing space. This optimization seems to be turned off

when inside of a Pre block."
Summary: Must press Space twice to insert space in Editor window → [dogfood] Must press Space twice to insert space in Editor window
marked dogfood because users of mail compose get unexpected results when trying
to edit.
Depends on: 16176
Whiteboard: [PDT+]
Putting on [PDT+] radar.
Added Syd Logan and S.Fraser to CC list
Blocks: 12658
Assignee: jfrancis → kin
Status: ASSIGNED → NEW
Reassigning to kin@netscape.com.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Fix checked in to Mozilla 5.0 tip.

    layout/base/src/nsCaret.cpp    revision 1.36
        - Modified DrawCaretWithContext so that we only
          adjust the caret position if we are within the
          frame's bounds.

    layout/html/base/src/nsTextFrame.cpp    revision 1.189
        - Modified GetPointFromOffset() to add the width
          of a space if the offset is after a trailing space
          and it was trimmed off the frame.

Fix was reviewed by sfraser@netscape.com.
Status: RESOLVED → VERIFIED
verified in 10/29 build.
You need to log in before you can comment on or make changes to this bug.