14573 - [dogfood] Must press Space twice to insert space in Editor window

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[cpratt]

Build ID: 1999092208
Platform: Windows NT (US-International keyboard layout)

To reproduce:
- Launch apprunner
- Select File | New | New Blank Window
- In the new Editor window that is generated, try typing anything

Result: Every time you want to type a space, you must press the spacebar
*twice*.

Expected result: One press of the spacebar should generate a space.

Comment 1

[buster]

I don't see this, maybe my fix to isEditable (not yet checked in) corrected this
problem?
assigned to joe.

Comment 2

[Joe Francis]

accepting bug / m12

Comment 3

[cpratt]

buster, I did not describe the problem accurately enough. When you press the
spacebar, a space actually *is* generated, but it is not reflected visually on
the screen. That is, if you type "hello^world" (the caret represents the space)
you see "hello world" on the screen - but if you just type "hello^" you will see
"hello|" where | represents the caret instead of "hello |".

Comment 4

[Kathleen :Brade]

*** Bug 15289 has been marked as a duplicate of this bug. ***

Comment 5

[Kathleen :Brade]

From Kin's bug:

"There seems to be some optimization in layout that does not extend the text

frame's width for a trailing space. This optimization seems to be turned off

when inside of a Pre block."

Comment 6

[buster]

marked dogfood because users of mail compose get unexpected results when trying
to edit.

Comment 7

[leger]

Putting on [PDT+] radar.

Comment 8

[scalkins]

Added Syd Logan and S.Fraser to CC list

Comment 9

[kinmoz]

Reassigning to [e-mail].

Comment 10

[kinmoz]

Fix checked in to Mozilla 5.0 tip.

    layout/base/src/nsCaret.cpp    revision 1.36
        - Modified DrawCaretWithContext so that we only
          adjust the caret position if we are within the
          frame's bounds.

    layout/html/base/src/nsTextFrame.cpp    revision 1.189
        - Modified GetPointFromOffset() to add the width
          of a space if the offset is after a trailing space
          and it was trimmed off the frame.

Fix was reviewed by [e-mail].

Comment 11

[sujay]

verified in 10/29 build.