1617673 - Bookmark properties window position and dimension are not saved/restored since version 73 update

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[that-ben]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

After Firefox version 73 update, right-click on any of your bookmarks and choose "Properties".

Actual results:

The bookmark properties window's position and dimension (width and height) are not saved (or restored) anymore, so it always opens a tiny window and it is always centered on the screen.

Expected results:

Before version 73, it always remembered its last position and dimension. This is very annoying, because the window is small and longer URL's are not visible unless you enlarge the window, which is itself an annoyance, because there is no maximize button and the border is very slim. For instance, URL's from Youtube playlists that end with &index=23367 benefit from being seen in the bookmark properties window.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marco Bonardo [:mak]]

We need a regression range for this, probably something with XUL removal changes.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88b25807638231dcf403d8f0b597fc770f1d24a4&tochange=e183cbb4983cfb3aecf97ab18fad916b91f89e7e

Comment 4

[Brian Grinstead [:bgrins]]

I'm assuming this is the same problem/solution as Bug 1616179. We should also audit the rest of changes in Bug 1585482 to preemptively find root elements without ids. I did file Bug 1616350 to put something in place to catch this problem.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 6

[Marco Bonardo [:mak]]

thank you Alice0775

Comment 7

[Ethan Tseng [:ethan]]

Brian, could you please set the priority flag?

Comment 8

[Brian Grinstead [:bgrins]]

Attachment: Bug 1617673 - Give the root element in the bookmark properties window an id so that persistence works again

The ID was removed in Bug 1585482 and moved to the child dialog element which breaks xulstore persistence.
This gives the dialog a new id and uses the original "bookmarkproperties" for the window so any existing
xulstore values will work without a ui migration.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bf266a19339
Give the root element in the bookmark properties window an id so that persistence works again r=mak

Comment 10

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/1bf266a19339

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bgrins, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Julien Cristau [:jcristau]]

Ping timeout, it's getting too late for 75 now. :(

Comment 14

[that-ben]

Thank god it's fixed. Thanks devs.