1617796 - Shutdown Crash in [@ ldap_abandon_ext] with Mac

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Wayne Mery (:wsmwk)]

#7 crash for Macs for 68.5.0. In the past 6 months there are not crashes prior to 68.3.0, so regression? Further, the earliest non-release crash is 71.0b1? buildid 20191113091023 bp-f4eae0cb-736f-43a5-af3e-b1e720191128
https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=ldap_abandon_ext&date=%3E%3D2019-08-25T03%3A02%3A00.000Z&date=%3C2020-02-25T03%3A02%3A00.000Z#graphs

This bug is for crash report bp-a72338e5-8aaa-456e-8ba9-4fa130200225. 75.0a1

Top 10 frames of crashing thread:

0 libldap60.dylib ldap_abandon_ext comm/ldap/c-sdk/libraries/libldap/abandon.c:96
1 XUL XUL@0x96f0 
2 XUL XUL@0x447d9e 
3 XUL XUL@0x44b558 
4 XUL XUL@0x54ced5 
5 XUL XUL@0x54dc5c 
6 XUL XUL@0x447d9e 
7 XUL XUL@0x44b558 
8 XUL XUL@0xa07cf3 
9 XUL XUL@0x9c0655 

This happened on shutdown, after I had attempted to delete the Mac OSX Address Book, which resulted in the following in the Error Console.

NS_ERROR_UNEXPECTED: Unexpected error'Unexpected error' when calling method: [nsIAbManager::deleteAddressBook] abCommon.js:372
21:49:42.542
An error occurred executing the button_delete command: [Exception... "Unexpected error'Unexpected error' when calling method: [nsIAbManager::deleteAddressBook]" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: chrome://messenger/content/addressbook/abCommon.js :: AbDeleteDirectory :: line 372" data: no] globalOverlay.js:104

Whether this triggered the crash remains to be seen. I'll try to reproduce.

For good measure - bp-ae11c080-2fc2-4014-b4b5-5fcdb0200225 68.5.0

Comment 1

[Wayne Mery (:wsmwk)]

I wonder if bp-f81efff2-478a-41e4-92e2-119a10200224 has the same cause. I hit this after doing search a couple times against All Address Books, then selecting a couple other address books, but not shutting down.
XUL@0x2fbf435 | XUL@0x162036e | XUL@0x2c0a8b7 | XUL@0x2c0ab0c | XUL@0x3f14f7c | XUL@0x3e9fadb | XUL@0x3ea6537 | XUL@0x3ed790c | XUL@0x3ed4825 | XUL@0x3ed7449 | XUL@0x3ed4ddc | XUL@0x2ff876c | XUL@0x2fd1c50 | XUL@0x2fd5b5e | XUL@0x2fbec34 | XUL@0x2fda4c...

Comment 2

[Wayne Mery (:wsmwk)]

THere is also Mac crash and linux crash ldap_memcache_abandon bp-67a5fa4c-0a99-4471-966f-0b6e10200328

Related to bug 1625677 ?
Crash in [@ md_UnlockAndPostNotifies] (nss) via ldap_msgdelete (ldap60.dll)

Comment 3

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/1e97b3c1f2224fbbf7c5479e2ec9f906d1949132/ldap/c-sdk/libraries/libldap/abandon.c#96
I have no idea.

Comment 4

[Wayne Mery (:wsmwk)]

Let's assume they are all shutdown crashes, and not so critical :)

Comment 5

[Wayne Mery (:wsmwk)]

I tried testing bug 1543183 with 76 beta and twice got the crash signature for this bug bp-3388ea5e-dff4-44ba-9491-332d80200504 Based solely on that I'd say this might be a duplicate of 1543183. It also fits with Bug 1543183's crash signature not having Mac crashes.

Also, like bug 1543183, the crash rate for ldap_abandon_ext has increased since mid-March https://crash-stats.mozilla.org/signature/?signature=ldap_abandon_ext&date=%3E%3D2020-02-05T02%3A05%3A00.000Z&date=%3C2020-05-05T02%3A05%3A00.000Z#graphs

Comment 6

[Ben Campbell]

(In reply to Wayne Mery (:wsmwk) from comment #5)

I tried testing bug 1543183 with 76 beta and twice got the crash signature for this bug bp-3388ea5e-dff4-44ba-9491-332d80200504 Based solely on that I'd say this might be a duplicate of 1543183. It also fits with Bug 1543183's crash signature not having Mac crashes.

I'm cautiously optimistic that it's the same issue as Bug 1625677 - after working on that one, I can see that the crash point on this one looks pretty similar. So I'm hoping the patch there will clear up both...

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Ben Campbell from comment #6)

...
I'm cautiously optimistic that it's the same issue as Bug 1625677 - after working on that one, I can see that the crash point on this one looks pretty similar. So I'm hoping the patch there will clear up both...

As noted in bug 1625677, its uplift to 68.9.0 may also have had in impact on bug 1617786's ldap_memcache_abandon signature [1]. And it certainly impacted version 78.
68.3.1 4
68.4.1 2
68.5.0 5
68.6.0 6
68.8.0 6
68.8.1 33
68.9.0 2
68.10.0 5
68.11.0 2
78.3.1 1
78.4.0 1
[1] https://crash-stats.mozilla.org/signature/?signature=ldap_memcache_abandon&date=%3E%3D2020-06-05T16%3A22%3A00.000Z&date=%3C2020-12-05T16%3A22%3A00.000Z#summary