1617915 - Allow setting output device id in MediaTrackGraph.

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, enhancement, P1)

Description

[Alex Chronopoulos [:achronop]]

Currently, MediaTrackGraph plays audio in the default output device. However, it would be able to play to any output device attached to the system, if the output device id was configurable.

With this bug, the output device id option will be exposed to MediaTrackGraph constructor. Any component that makes use of MTG will be able to define the output device id. If the device id is NULL the default device will be chosen.

This is required for setSinkId.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1617915 - Expose output device id when MediaTrackGraph is created. r?padenot

In order to be able to change the audio output device, the device id is exposed to the constructor of MediaStreamGraph. Any component that gets/creates an MTG will be able to provide the device id in order to determine the desired output device. If the provided device id is null the default device will be used.

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1617915 - Enhance MockCubeb to support using it in MediaTrackGraph unit tests. r?padenot

MockCubeb simulates the behavior of libcubeb and allows us to exercise media Gecko code from gtests. Some enhancements have been made to make it usable for exercising the MTG.

• Define the get_max_channel_count method.
• Define a mock cubeb_stream class that allow to handle many streams with the same (mock) cubeb context.

Depends on D64133

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1617915 - Create unit tests to verify that MTG sets the expected device id. r?padenot

Create gtests to verify that the device id provided to the constructor of MTG will be the one used by cubeb as output device id. In addition to that, verify that using a different device id will result in creating/getting a different MTG instance.

Depends on D64134

Comment 4

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=290375410&revision=22f6d7d24932ed13ea3087b301bbcd2aea964ed6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3fcadf709f0
Expose output device id when MediaTrackGraph is created. r=padenot
https://hg.mozilla.org/integration/autoland/rev/bfb1aaa33317
Enhance MockCubeb to support using it in MediaTrackGraph unit tests. r=padenot
https://hg.mozilla.org/integration/autoland/rev/e144f3d78dfa
Create unit tests to verify that MTG sets the expected device id. r=padenot

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e3fcadf709f0
https://hg.mozilla.org/mozilla-central/rev/bfb1aaa33317
https://hg.mozilla.org/mozilla-central/rev/e144f3d78dfa