1622897 - Intermittent TestAudioTrackGraph.SetOutputDeviceID | Expected equality of these values:

Status: RESOLVED FIXED

(GeckoView :: Media, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: malexandru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=293356085&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VBw-qIfhSvum0GDjfeARGw/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - TEST-START | OpusAudioTrackEncoder.FrameEncode
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - TEST-PASS | OpusAudioTrackEncoder.FrameEncode | test completed (time: 30ms)
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - TEST-START | TestAudioTrackGraph.DifferentDeviceIDs
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - TEST-PASS | TestAudioTrackGraph.DifferentDeviceIDs | test completed (time: 8ms)
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - TEST-START | TestAudioTrackGraph.SetOutputDeviceID
[task 2020-03-16T17:12:15.330Z] 17:12:15 WARNING - TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.SetOutputDeviceID | Expected equality of these values:
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - cubeb->GetCurrentOutputDeviceID()
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - Which is: NULL
[task 2020-03-16T17:12:15.330Z] 17:12:15 INFO - reinterpret_cast<cubeb_devid>(1)
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - Which is: 0x1
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - After init confirm the expected output device id @ /builds/worker/checkouts/gecko/dom/media/gtest/TestAudioTrackGraph.cpp:98
[task 2020-03-16T17:12:15.331Z] 17:12:15 WARNING - TEST-UNEXPECTED-FAIL | TestAudioTrackGraph.SetOutputDeviceID | test completed (time: 2ms)
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - TEST-START | BenchmarkStorage.MovingAverage
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - TEST-PASS | BenchmarkStorage.MovingAverage | test completed (time: 0ms)
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - TEST-START | BenchmarkStorage.ParseStoredValue
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - TEST-PASS | BenchmarkStorage.ParseStoredValue | test completed (time: 0ms)
[task 2020-03-16T17:12:15.331Z] 17:12:15 INFO - TEST-START | BenchmarkStorage.PrepareStoredValue

Comment 1

[Cosmin Sabou [:CosminS]]

Alex, this looks to be from Bug 1617915: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C7.0%2Cx86-64%2Copt%2Ctest-android-em-7.0-x86_64%2Fopt-geckoview-gtest-1proc%2C%28gtest%29&tochange=b558f594712283a4ce1d5df2892d93e239969f2a&fromchange=05ebd9c6bcc9394f0afa10c6ad7d7bf52d53e933&selectedJob=293608396

Comment 2

[Alex Chronopoulos [:achronop]]

Thank you, I will have a look.

Comment 3

[Intermittent Failures Robot]

16 failures in 908 pushes (0.018 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 11
• mozilla-central: 3
• try: 2

Platform breakdown:

• android-em-7-0-x86_64: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-18&endday=2020-03-18&tree=all

Comment 4

[Intermittent Failures Robot]

17 failures in 935 pushes (0.018 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 11
• mozilla-central: 4
• try: 2

Platform breakdown:

• android-em-7-0-x86_64: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-19&endday=2020-03-19&tree=all

Comment 5

[Intermittent Failures Robot]

77 failures in 4955 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #18 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 48
• try: 17
• mozilla-central: 12

Platform breakdown:

• android-em-7-0-x86_64: 76
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-16&endday=2020-03-22&tree=all

Comment 6

[Intermittent Failures Robot]

28 failures in 873 pushes (0.032 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 10
• try: 16
• mozilla-central: 2

Platform breakdown:

• android-em-7-0-x86_64: 28

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-23&endday=2020-03-23&tree=all

Comment 7

[Intermittent Failures Robot]

17 failures in 789 pushes (0.022 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 4
• autoland: 11
• mozilla-central: 2

Platform breakdown:

• android-em-7-0-x86_64: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-24&endday=2020-03-24&tree=all

Comment 8

[Stefan Hindli [:stefan_hindli]]

Over the last 7 days there are 62 failures present on this bug. These happen on windows10-64 and android-em-7-0-x86_64.
Here is the most recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294837288&repo=autoland&lineNumber=4832

Comment 9

[Alex Chronopoulos [:achronop]]

Thank you for pinging me. I have been investigated with lower priority. My latest try run is in [1]. TBH is not a very important error and I expect to be fixed by the following patches. However, they take some time. I'll check if I can do something in the meantime to avoid the error.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b206c4bfd44bc1e1cce4c2e5a7be734470b5ddc9

Comment 10

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=295025210&revision=a5a40ce22f7f85c23daec0c2a51255e3a1768807

Comment 11

[Alex Chronopoulos [:achronop]]

The intermittent happens because of the previous test (TestAudioTrackGraph, DifferentDeviceIDs). The cubeb stream init method, of the previous test, executed (asynchronously) late so when the current test is running we still get the values from the previous test. I will implement a logic to wait for the graphs in the previous test to init and shut down before the test end.

Comment 12

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25f274b0ecf8f2aa3c931d1b978eebbed8a47a80

Comment 13

[Intermittent Failures Robot]

19 failures in 884 pushes (0.021 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• mozilla-central: 3
• autoland: 11
• try: 5

Platform breakdown:

• android-em-7-0-x86_64: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-27&endday=2020-03-27&tree=all

Comment 14

[Andreea Pavel [:apavel]]

Alex can this test be disabled?

Comment 15

[Intermittent Failures Robot]

20 failures in 267 pushes (0.075 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 4
• autoland: 5
• try: 11

Platform breakdown:

• android-em-7-0-x86_64: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-28&endday=2020-03-28&tree=all

Comment 16

[Intermittent Failures Robot]

120 failures in 4773 pushes (0.025 failures/push) were associated with this bug in the last 7 days.

This is the #3 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 58
• try: 46
• mozilla-central: 16

Platform breakdown:

• android-em-7-0-x86_64: 120

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-23&endday=2020-03-29&tree=all

Comment 17

[Alex Chronopoulos [:achronop]]

Sure, please go on and disable it. This will give me the time to fix it properly. Thanks!

Comment 18

[Alex Chronopoulos [:achronop]]

The new problem is that the message used to control the expected result is executed in the Fallback driver before the AudioCallbackDriver::Init. In Bug 1493990 I have implemented a way to signal back from the MTG when the actual audio has started which is what we need here. This is planned to be landed in the following weeks.

Comment 19

[Intermittent Failures Robot]

15 failures in 1003 pushes (0.015 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 12
• try: 1
• mozilla-central: 2

Platform breakdown:

• android-em-7-0-x86_64: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-30&endday=2020-03-30&tree=all

Comment 20

[Andreea Pavel [:apavel]]

Attachment: Bug 1622897 - disable TestAudioTrackGraph.SetOutputDeviceID on android r=jmaher

Comment 21

[Joel Maher ( :jmaher ) (UTC -8)]

:achronop, please make sure in Bug 1493990 that you revert this change.

Comment 22

[Alex Chronopoulos [:achronop]]

Sure. Can we keep this bug open? I will land the corresponding earlier than bug 1493990 in order to fix this.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b94c124b120c
disable TestAudioTrackGraph.SetOutputDeviceID on android r=jmaher

Comment 24

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b94c124b120c

Comment 25

[Intermittent Failures Robot]

21 failures in 5015 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 14
• try: 5
• mozilla-central: 2

Platform breakdown:

• android-em-7-0-x86_64: 20
• linux1804-64-asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-03-30&endday=2020-04-05&tree=all

Comment 26

[Intermittent Failures Robot]

1 failures in 4823 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform breakdown:

• android-em-7-0-x86_64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-04-06&endday=2020-04-12&tree=all

Comment 27

[Intermittent Failures Robot]

4 failures in 4528 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3
• mozilla-central: 1

Platform breakdown:

• android-em-7-0-x86_64: 3
• linux1804-64-asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1622897&startday=2020-04-13&endday=2020-04-19&tree=all

Comment 28

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1622897 - Fix intermitten by waiting for the right time to check the result. r?padenot

First update the previous test,TestAudioTrackGraph.DifferentDeviceIDs, to make sure that has been finished before starting the current one. The reason is that when the cubeb_stream_init method, of the previous test, is executed (asynchronously) late, the verified test results, of the current test, are wrong (it gets the values of the previous test). Second, on the currently failing test, use the promise returned from the new MTG::NotifyWhenDeviceStarted() method, that it is guaranteed to be resolved after the cubeb_stream_init() so the correct/expected device id will be found and compared. Finally, create a basic logging mechanism in MockCubeb for easier debugging.

Comment 29

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14d0105e4b05ef7191f62c7836187b32b99155b1

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b6cbcc81bdd
Fix intermitten by waiting for the right time to check the result. r=padenot

Comment 31

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2b6cbcc81bdd

Comment 32

[Andreea Pavel [:apavel]]

Test is no longer disabled, but fixed: https://searchfox.org/mozilla-central/source/dom/media/gtest/TestAudioTrackGraph.cpp#15

Comment 33

[Intermittent Failures Robot]

1 failures in 1479 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-esr78: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1622897&startday=2020-11-23&endday=2020-11-29&tree=all

Comment 34

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.