1617960 - Add a favicon for the Account Manager tab

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Richard Marti (:Paenglab)]

With the Account Manager in tab we should add a favicon to better differentiate to other tabs and give a better recognition of the tab.

I tried to add to the accountManager.xhtml a <link rel="shortcut icon" href="path/to/icon"/> but this didn't work. It seems the content tab don't support this.

Khushil, is it somehow possible to give the AM tab a attribute like type="AccountManager" like we have for other tabs? Then we could assign a icon through CSS .

Comment 1

[Khushil Mistry [:khushil324]]

We can search for a tab here just as below: https://searchfox.org/comm-central/source/mailnews/base/prefs/content/accountUtils.js#320

for (let tabInfo of tabmail.tabInfo) {
    let tab = tabmail.getTabForBrowser(tabInfo.browser);
    if (tab && tab.urlbar && tab.urlbar.textContent == "about:accountsettings") {
      tab.setAttriubte("type", "AccountManager");
      break;
    }
}

Comment 2

[Richard Marti (:Paenglab)]

Thanks. I needed to change the if () to

if (
  tab &&
  tab.urlbar &&
  tab.urlbar.textContent == "about:accountsettings"
)

But now I get tab.setAttribute is not a function.

Please can you help here?

Comment 3

[Khushil Mistry [:khushil324]]

(In reply to Richard Marti (:Paenglab) from comment #2)

But now I get tab.setAttribute is not a function.

Please can you help here?

It will be: tab.tabNode.setAttribute("type", "AccountManager");

Comment 4

[Khushil Mistry [:khushil324]]

Any updates on this?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1617960-account-manager-icon.patch

(In reply to Khushil Mistry [:khushil324] from comment #4)

Any updates on this?

Yes, this one works when opening the AM. But when starting TB with with a open AM tab it doesn't get the icon.

Any hints where the code should be placed to work with am already opened AM tab on startup? Or do we say it's unlikely that this tab stays open for long time?

Comment 6

[Magnus Melin [:mkmelin]]

(Sorry, I don't have anything to add atm.)

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: 1617960-account-manager-icon.patch

I checked this. It is working. For the issue during the restoration of the tabs, I have added an if-condition in specialTabs.js.

if (aPersistedState.tabURI == "about:accountsettings") {
  tab.tabNode.setAttribute("type", "accountManager");
}

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9132825 [details] [diff] [review]
1617960-account-manager-icon.patch

Many thanks, this works for me too. Better we let review this from a neutral person. :-)

Comment 9

[Richard Marti (:Paenglab)]

Attachment: 1617960-account-manager-icon.patch

Added Khushil to the author field.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08098cce2d2c
Add a favicon for the Account Manager tab. r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/011ee25ec397
follow-up - remove a stray semicolon. rs=linting-only DONTBUILD