1617984 - "./mech bootstrap" fails on Archlinux when PKGDEST is set in /etc/makepkg.conf

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[sekhavat17]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

In archlinux:

1. Uncomment the line #PKGDEST=/home/packages in /etc/makepkg.conf
2. Clone gecko-dev repository and cd gecko-dev
3. ./mesh bootstrap

Actual results:

The pkg.tar.xz file is built in /home/packages, instead of cwd and the script will not be able to locate it and the following exception is thrown:

Error running mach:

['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

IndexError: list index out of range

File "/home/mohammad/src/gecko-dev/python/mozboot/mozboot/mach_commands.py", line 44, in bootstrap
bootstrapper.bootstrap()
File "/home/mohammad/src/gecko-dev/python/mozboot/mozboot/bootstrap.py", line 456, in bootstrap
getattr(self.instance, 'install_%s_packages' % application)()
File "/home/mohammad/src/gecko-dev/python/mozboot/mozboot/archlinux.py", line 92, in install_browser_artifact_mode_packages
self.ensure_browser_packages(artifact_mode=True)
File "/home/mohammad/src/gecko-dev/python/mozboot/mozboot/archlinux.py", line 102, in ensure_browser_packages
self.aur_install(self.BROWSER_AUR_PACKAGES)
File "/home/mohammad/src/gecko-dev/python/mozboot/mozboot/archlinux.py", line 214, in aur_install
self.makepkg(name)
File "/home/mohammad/src/gecko-dev/python/mozboot/mozboot/archlinux.py", line 188, in makepkg
pack = glob.glob(name + '.pkg.tar.xz')[0]

Expected results:

The environment variable "PKGDEST=." should have been set before makepkg so that the error doesn't happen and bootstrap continues.

Comment 1

[sekhavat17]

Attachment: Bug 1617984 - Fix mach bootstrap failure on Archlinux when PKGDEST is set; r=chmanchester

Makepkg does have a commented config in /etc/makepkg.conf to set the path for packages to be built:
'''
'''
When you uncommit this line, packages will be built in the specified path, instead of cwd. This causes the bootstrap script to fail.

This commit will override the PKGDEST config so that package is built in cwd and could be located by the following lines of script.

Comment 2

[sekhavat17]

I just created a patch to fix this: https://phabricator.services.mozilla.com/D64195

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a50491a731c2
Fix mach bootstrap failure on Archlinux when PKGDEST is set; r=firefox-build-system-reviewers,rstewart

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a50491a731c2