Closed Bug 1617992 Opened 4 years ago Closed 4 years ago

Add a bouncer link for the Mac pkg file

Categories

(Release Engineering :: Release Automation: Bouncer, enhancement)

Product:
Release Engineering
Component:
Release Automation: Bouncer
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr6877+ fixed, firefox76 wontfix, firefox77+ fixed, firefox78+ fixed)

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox-esr68 77+ fixed
firefox76 --- wontfix
firefox77 + fixed
firefox78 + fixed

People

(Reporter: mkaply, Assigned: mtabara)

References

Details

Attachments

(2 files)

[intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release-
RyanVM
: approval-mozilla-esr68+
Details | Review
[bouncerscript] Add support for Mac PKG format
64 bytes, text/x-github-pull-request
Details | Review

Our current Mac bouncer link is:

https://download.mozilla.org/?product=firefox-latest-ssl&os=osx&lang=en-US

This downloads the DMG file.

We'd like a link to the PKG file as well.

based on the Windows naming, it would probable be:

https://download.mozilla.org/?product=firefox-pkg-latest-ssl&os=osx&lang=en-US

Callek, do you recall why you went with a separate product for msi, rather than a different os like win64-msi ? Was there some technical limitation ?

Flags: needinfo?(bugspam.Callek)

I don't think there was a technical limitation, so much as that was what the www was designed around (calling it a product) -- I could see it either way.

Flags: needinfo?(bugspam.Callek)

pmac, any preference for how we proceed here ?

Flags: needinfo?(pmac)

I don't recall why we did it in the product rather than the platform for msi either. It make sense to me since win64 really is the platform and the different packaging doesn't affect that, but it'd work either way I'm sure. But since we did it in the product for Windows let's keep it consistent for Mac. Consistency is all I really care about so we can keep our code as simple as possible. So I'm +1 on :mkaply's suggestion in comment #0.

Flags: needinfo?(pmac)

Is this an easy thing to get done? I want to update the links on our enterprise download page.

Pinging on this one.

Flags: needinfo?(nthomas)
Flags: needinfo?(bugspam.Callek)
Depends on: 1631526

(In reply to Mike Kaply [:mkaply] from comment #6)

Pinging on this one.

Sorry! I just filed bug 1631526 with cloud ops to create the product for us, (we no longer have the direct access) -- once they create the latest entries we can add the automation support relatively easily.

I think this all makes sense from the discussion I've seen here.

Flags: needinfo?(bugspam.Callek)
Flags: needinfo?(nthomas)

Slipped my radar the other week, will take care of it this week.

Assignee: nobody → mtabara

I've got most of the patches ready to land or already landed.

@mkaply: Quick question, just to confirm - we're not expected to provide this for Devedition, right? I couldn't find any pkg at all for it within our release artifacts.

Flags: needinfo?(mozilla)

No, not needed for devedition.

Flags: needinfo?(mozilla)

(In reply to Mike Kaply [:mkaply] from comment #12)

No, not needed for devedition.

Cool, thanks. You're so fast :)

Pushed a9cb5004fb7d020c22098588a4447a690a8d5a21 to production-bouncerscript to back out https://github.com/mozilla-releng/scriptworker-scripts/pull/204 , due to bug 1634826.

Depends on: 1634826

(In reply to Aki Sasaki [:aki] (he/him) (UTC-7) from comment #14)

Pushed a9cb5004fb7d020c22098588a4447a690a8d5a21 to production-bouncerscript to back out https://github.com/mozilla-releng/scriptworker-scripts/pull/204 , due to bug 1634826.

Thanks for backing out, sorry for the bustage. Will investigate to see what went wrong.

The locations products have been created in bouncer admin side so we can land the central bits for nightlies.

Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2535ad979eff
add bouncer support for Mac PKG format. r=rail

Note to self:

  1. Wait for https://bugzilla.mozilla.org/show_bug.cgi?id=1617992#c17 to get to central
  2. Update production-bouncerscript to point to HEAD or 36aeb8b5 that contains my PR.
  3. Confirm that nightlies are working fine and close bug 1634826
  4. leave for 1-2 days to ensure are working fine on central, then uplift patch from 1 to beta and release to complete this bug.

https://hg.mozilla.org/mozilla-central/rev/2535ad979eff

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #18)

Note to self:

  1. Wait for https://bugzilla.mozilla.org/show_bug.cgi?id=1617992#c17 to get to central

done

  1. Update production-bouncerscript to point to HEAD or 36aeb8b5 that contains my PR.

done

  1. Confirm that nightlies are working fine and close bug 1634826

They are broken because of a typo I introduced when initially creating the nightly locations. It's being fixed in bug 1631526 comment 11.

  1. leave for 1-2 days to ensure are working fine on central, then uplift patch from 1 to beta and release to complete this bug.

The breakage affeects only the nightly central locations, we can proceed with uplifting this to beta for now to see how it behaves.

Attachment #9144644 - Attachment description: Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail → [intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail

Comment on attachment 9144644 [details]
[intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail

Beta/Release Uplift Approval Request

  • User impact if declined: Enable PKG new format for Mac users in bouncer so that we can advertise it from https://download.mozilla.org/
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9144644 - Flags: approval-mozilla-beta?

[Tracking Requested - why for this release]:

status-firefox77: --- → affected

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #18)

Note to self:

  1. Wait for https://bugzilla.mozilla.org/show_bug.cgi?id=1617992#c17 to get to central
  2. Update production-bouncerscript to point to HEAD or 36aeb8b5 that contains my PR.
  3. Confirm that nightlies are working fine and close bug 1634826

1-2-3 now done.

  1. leave for 1-2 days to ensure are working fine on central, then uplift patch from 1 to beta and release to complete this bug.

once RelMan uplifts this to mozilla-beta, I'll wait for one release to go green before requesting uplift to release/esr68.

Comment on attachment 9144644 [details]
[intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail

Approved for the next beta, thanks.

Attachment #9144644 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
  1. leave for 1-2 days to ensure are working fine on central, then uplift patch from 1 to beta and release to complete this bug.

once RelMan uplifts this to mozilla-beta, I'll wait for one release to go green before requesting uplift to release/esr68.

Both bouncer-jobs for Firefox 77.0b4 are now green - https://firefox-ci-tc.services.mozilla.com/tasks/groups/a-5E6KyATyyItU60ylRnOw
Requesting this to be uplifted to release/esr68.

Comment on attachment 9144644 [details]
[intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail

Beta/Release Uplift Approval Request

  • User impact if declined: add support for Mac PKG format in bouncer
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9144644 - Flags: approval-mozilla-release?

Comment on attachment 9144644 [details]
[intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: add support for Mac PKG format in bouncer
  • User impact if declined:
  • Fix Landed on Version:
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String or UUID changes made by this patch:
Attachment #9144644 - Flags: approval-mozilla-esr68?

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #27)

  1. leave for 1-2 days to ensure are working fine on central, then uplift patch from 1 to beta and release to complete this bug.

once RelMan uplifts this to mozilla-beta, I'll wait for one release to go green before requesting uplift to release/esr68.

Both bouncer-jobs for Firefox 77.0b4 are now green - https://firefox-ci-tc.services.mozilla.com/tasks/groups/a-5E6KyATyyItU60ylRnOw
Requesting this to be uplifted to release/esr68.

E.g. https://download.mozilla.org/?product=firefox-beta-pkg-latest-ssl&os=osx

What's driving the release approval request here? Is this something urgent enough that it needs to be in a 76 dot release instead of riding 77 to release in June?

Flags: needinfo?(mtabara)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #31)

What's driving the release approval request here? Is this something urgent enough that it needs to be in a 76 dot release instead of riding 77 to release in June?

302 to :mkaply

Flags: needinfo?(mtabara) → needinfo?(mozilla)

we can just do beta uplift here. I mainly just want it to match when the next ESR comes out.

Flags: needinfo?(mozilla)

Comment on attachment 9144644 [details]
[intree] Bug 1617992 - add bouncer support for Mac PKG format. r=nthomas,rail

Thanks. Approved for 68.9esr to ride alongside Fx77. Not taking this for 76.*.

Attachment #9144644 - Flags: approval-mozilla-release?
Attachment #9144644 - Flags: approval-mozilla-release-
Attachment #9144644 - Flags: approval-mozilla-esr68?
Attachment #9144644 - Flags: approval-mozilla-esr68+

All done here, once we ship next release 77.0 out the door along with 68.9esr, we'll have the PKG aliases available.
All done here - I'll add a todo for myself for release day to check on this.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: