1618057 - Figure out the right BrowsingContext to pass to DocumentLoadListener

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P2)

Description

[Matt Woodrow (:mattwoodrow)]

We currently pass the BrowserParent into DocumentLoadListener, and then grab the BrowsingContext from that.

This will vary depending on whether we're an in-process <iframe> or an OOP one, in ways that don't make a lot of sense.

Bug 1616716 is making us pass a BrowsingContext directly, but preserves the same behaviour (the BC of the nearest ancestor that is a process root).

We should figure out what the actual requirements are, and clean this up.

Comment 1

[Chris Peterson [:cpeterson]]

non-Fission-specific cleanup

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1618057 - Use the target BrowsingContext of the load, rather than the process-top BrowsingContext when initializing DocumentLoadListener. r?nika

This also fixes the Window lookup in nsExternalAppHandler, which was the reason for previously needing the process-top BrowsingContext.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/363f7fdf5e0a
Use the target BrowsingContext of the load, rather than the process-top BrowsingContext when initializing DocumentLoadListener. r=nika

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/363f7fdf5e0a