Closed Bug 1619240 Opened 4 years ago Closed 3 years ago

Remove dom/xul/test/test_bug486990.xhtml test

Categories

(Core :: XUL, defect, P5)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

Attachments

(1 file)

Follow-up for bug 1618163:

Changing the code from bug 1618163 to assert that the active window check happens in a chrome process only makes the assertion fire in dom/xul/test/test_bug486990.xhtml .

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291237996&repo=try&lineNumber=8293

The priority flag is not set for this bug.
:bgrins, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bgrinstead)
Flags: needinfo?(bgrinstead)
Priority: -- → P5
Summary: dom/xul/test/test_bug486990.xhtml run XUL popup launching code in a content process → dom/xul/test/test_bug486990.xhtml runs XUL popup launching code in a content process

Content processes shouldn't be able to create popups, but this test tries to. If that's true, then why isn't this test marked as failing on Fission?

https://searchfox.org/mozilla-central/rev/9f074fab9bf905fad62e7cc32faf121195f4ba46/dom/xul/test/mochitest.ini#3-4

Fission Milestone: --- → ?

(In reply to Henri Sivonen (:hsivonen) from comment #0)

Changing the code from bug 1618163 to assert that the active window check happens in a chrome process only makes the assertion fire in dom/xul/test/test_bug486990.xhtml .

@ Henri: Nika recommends deleting this test and re-enabling your active window assertion. This test uses remote XUL, which we don't care about.

The test tries to load a XUL window in a content process. This test is running as a plain mochitest, not browser chrome.

Fission Milestone: ? → M6b
Flags: needinfo?(hsivonen)
Summary: dom/xul/test/test_bug486990.xhtml runs XUL popup launching code in a content process → Remove dom/xul/test/test_bug486990.xhtml test
Fission Milestone: M6b → M6c

Shouldn't block Fission.

Fission Milestone: M6c → ---
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27b52c5ea6b9
Remove dom/xul/test/test_bug486990.xhtml test. r=nika
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: