In AudioBufferSourceNode when loop is true, duration is not taken into account
Categories
(Core :: Web Audio, enhancement, P3)
Tracking
()
People
(Reporter: kai670, Assigned: padenot, NeedInfo)
References
Details
Attachments
(4 files, 6 obsolete files)
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.116 Safari/537.36
Steps to reproduce:
https://jsfiddle.net/kai670/h1ex5ky8/7/
Actual results:
The sound is played in an infinite loop that never ends.
Expected results:
The sound must be played in loop during 5 seconds.
That is the behaviour in Chrome and what I understand reading the spec:
The duration parameter describes the duration of sound to be played, expressed as seconds of total buffer content to be output, including any whole or partial loop iterations. The units of duration are independent of the effects of playbackRate. For example, a duration of 5 seconds with a playback rate of 0.5 will output 5 seconds of buffer content at half speed, producing 10 seconds of audible output. A RangeError exception MUST be thrown if duration is negative.
Updated•5 years ago
|
Comment 1•5 years ago
|
||
The specified behavior changed for https://github.com/WebAudio/web-audio-api/issues/421.
The regression from that has also been resolved now.
Updated•4 years ago
|
Updated•4 years ago
|
The AudioBufferSourceNode can now be looping and stop after duration.
Comment 9•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f74c10d88304
https://hg.mozilla.org/mozilla-central/rev/99ac03bfe9ce
https://hg.mozilla.org/mozilla-central/rev/feff7b5ed5b1
Comment 10•4 years ago
|
||
Reopening because of the above regression.
Comment 11•4 years ago
|
||
Backed out from trunk and beta in bug 1650030.
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Comment 14•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 15•4 years ago
|
||
It allows simpler handling of duration, and it works on looping sources.
Also removed now unnecessary calculations ont mBufferEnd to handle duration.
Comment 16•4 years ago
|
||
Depends on D84402
Comment 17•4 years ago
|
||
Depends on D84403
Comment 18•4 years ago
|
||
Let me know if you want to change NS_lround() function call too.
Depends on D84481
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 19•4 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:koalab1999, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 20•4 years ago
|
||
I've added some test jobs to https://treeherder.mozilla.org/#/jobs?repo=try&revision=92a62d9bfad13e8a17b8377e9385ee0d1a97ed30.
If those complete successfully (or with only unrelated failures) please add the "Check-in Needed" project "Tag" to https://phabricator.services.mozilla.com/differential/revision/edit/85583/
Assignee | ||
Comment 21•4 years ago
|
||
They don't, it's probably not too hard to fix them.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 22•4 years ago
|
||
Comment 24•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bfda8cd8ce2f
https://hg.mozilla.org/mozilla-central/rev/3aa921cab417
https://hg.mozilla.org/mozilla-central/rev/97ecf4557cf4
https://hg.mozilla.org/mozilla-central/rev/0c7b5d5a2307
Description
•