1618346 - Add browser import to Firefox menu

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P1)

Description

[Ed Lee :Mardak]

Attachment: import from firefox menu design

Bryan provided the attached design which seems to just make the File menu item available from the Firefox menu

https://searchfox.org/mozilla-central/search?q=menu-file-import-from-another-browser

Comment 1

[Ed Lee :Mardak]

https://mozilla.invisionapp.com/share/QCW68066D2X

Doesn't look like that Import icon exists here https://searchfox.org/mozilla-central/source/browser/themes/shared/icons

aaron, can you provide a svg for that? Or maybe we can be consistent with about:login's menu using https://searchfox.org/mozilla-central/source/browser/themes/shared/icons/save.svg (see attachment 9129249 [details])

Comment 2

[Aaron Benson]

Hey Ed, you can find that icon here: https://design.firefox.com/icons/viewer/#import

Let me know if that doesn't work for some reason.

Comment 3

[Ed Lee :Mardak]

Oh ha ha excellent! We did use it as part of the manual migration message but removed as part of bug 1545487. I wonder if I should switch over about:login's icon to use this new one…

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1618346 - Add browser import to Firefox menu r?MattN!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e37d17605438
Add browser import to Firefox menu r=MattN,fluent-reviewers,flod

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e37d17605438

Comment 7

[Dão Gottwald [:dao]]

Does this need documentation on SUMO?

Comment 8

[Oana Botisan, Desktop QA]

I verified the fix on latest Nightly 76.0a1 and beta 75.0b3 using Windows 10 x64, macOS 10.15 and Ubuntu 16.04 x64. The "Import from Another Browser..." button is displayed in the Firefox menu just above "What's New" option.

Comment 9

[Cristina Coroiu [:ccoroiu]]

Backed out changeset e37d17605438 (bug 1618346) for causing bug 1620536
Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/e809b7b2798d670fd9cf6233b12ed95ac59ed8c4

Comment 10

[Julien Cristau [:jcristau]]

Attachment: Bug 1618346 - restore import icon referenced by about:logins. r?mardak

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/16dc8ee25096

Comment 12

[Ed Lee :Mardak]

Looks like this got backed out.