1618535 - [rel=preload] as="fetch" preload support

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Honza Bambas (:mayhemer)]

Part of Design documentation for rel=preload

Please see the implementation notes for “fetch” type.

The idea is to have a loader - in this case more a preloader - that can be used to preload any "as" type of resource. Primarily it will be used for "fetch", but we may also want to use it for "font" (in a different bug).

The fetch loader should hang off the document as all other loaders (script, style, ...) do.

It will provide a method taking a channel and a key (as defined in the design doc). It will asyncOpen the channel with a class derived from PreloaderBase class as the listener, and register it in Document.PreloadService, similarly as we want for other loaders in bug 1618292 el al. There is no need to do anything else, this exposes the preload data and status in Document.PreloadService under the key for <link rel=preload> DOM nodes and final data consumers, like fetch and XHR.

There will be no coalescing inside the loader, it's up to the callers to coalesce by checking Document.PreloadService.LookupPreload for the key.

Wondering if this could be reduced to a helper static function only, taking Document, nsIChannel and key as only arguments, possibly returning PreloaderBase as a result for use.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: Bug 1618535 - Implement preloading for as="fetch" type

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7a40b7e663f
Implement preloading for as="fetch" type r=kershaw,baku

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d7a40b7e663f

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1618535 - Add missing `#include "nsIDocShell.h"` to unbreak the Thunderbird build

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1706d4d54ec6
Add missing `#include "nsIDocShell.h"` to unbreak the Thunderbird build r=baku

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1706d4d54ec6

Comment 7

[Honza Bambas (:mayhemer)]

Thanks, Geoff!