1618616 - Button overlap in Accounts Settings pane with smaller windows

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: overlap.png

When the Default Identity description wraps to a second line, because the window is too small, the "Manage Identities..." button overlaps the "Edit SMTP server...". This comes probably because of the change to use <fieldset>.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1618616-move-manageIdentities-box.patch

With moving the manageIdentities block inside the fieldset the issue is fixed. Visually is no difference as we don't draw borders around the fieldset.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9129559 [details] [diff] [review]
1618616-move-manageIdentities-box.patch

Review of attachment 9129559 [details] [diff] [review]:
-----------------------------------------------------------------

I think it would be better to handle this in another way. Fieldset has a semantic meaning, so we should not mix manage identities in under the Default identity fieldset

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1618616-use-vbox-for-Identitx.patch

When I use a <vbox> instead of the <fieldset> the vbox shifts the following elements down what the <fieldset> does not.

I tried different things and this is the only thing that works. When you disagree with the fix, I'm out of solutions and you can try to fix it.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9129842 [details] [diff] [review]
1618616-use-vbox-for-Identitx.patch

Review of attachment 9129842 [details] [diff] [review]:
-----------------------------------------------------------------

Of the two evils, I'd rather go with moving it inside the <fieldset>

This really seems like a rendering bug. Hopefully it would solve itself sooner or later. Perhaps we should just let it linger on for a while and only fix it closer to release if needed anymore?

Comment 6

[Richard Marti (:Paenglab)]

It doesn't seem that m-c fixes this issue until 78 is live and bug 1628497 will made it happen always.

Shouldn't we land this? If m-c fixes it, we still can back-out it again.

Comment 7

[Magnus Melin [:mkmelin]]

Yeah let's land it and add a comment in the code so hopefully we can move it to the proper location in the future.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: 1618616-move-manageIdentities-box.patch

Added: <!-- When the fieldset overflow works, move this back above the last separator -->

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b12d34446556
Move the manageIdentities box inside of the fieldset to workaround rendering problems for narrow screens. r=mkmelin