1618656 - Minor flexbox cleanup again

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Similar to bug 1614082, I have some patches accumulated while poking flexbox' code.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1618656 - Revise documentation and fix typos in nsFlexContainerFrame.cpp. r=dholbert

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1618656 - Rename finalFlexItemCBSize to finalFlexItemSize. r=dholbert

finalFlexItemCBSize sounds like the size of the "containing block" of
the flex item, which feels wrong to me.

Depends on D64676

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1618656 - Eliminate the nsPresContext argument for nsFlexContainerFrame's methods. r=dholbert

If nsPresContext is needed, we can always use nsIFrame::PresContext() to
retrieve it. This is what grid container does.

Depends on D64677

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1618656 - Remove unused lineIndex counter in a for-loop. r=dholbert

Depends on D64678

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1618656 - Convert typedef to "using declarations" for flex container's helper classes. r=dholbert

IntrinsicISizeType is used only once. We can just prepend nsLayoutUtils
at the call site.

Depends on D64679

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1618656 - Sort #include declarations in nsFlexContainerFrame.{h,cpp}. r=dholbert

With two minor tweaks:

1. Remove "mozilla/UniquePtr.h" from cpp since it is already included in
   the header.

2. Use "mozilla/WritingModes.h" instead "WritingModes.h" in cpp.
   WritingModes.h was exported under "mozilla/", and it works without
   "mozilla/" because we are in the same directory.

Depends on D64680

Comment 7

[Daniel Holbert [:dholbert]]

Thanks for doing this cleanup!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a389ce4d36d
Revise documentation and fix typos in nsFlexContainerFrame.cpp. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/a2d65bda6c55
Rename finalFlexItemCBSize to finalFlexItemSize. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/2b7adf8582fa
Eliminate the nsPresContext argument for nsFlexContainerFrame's methods. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/1830e0579510
Remove unused lineIndex counter in a for-loop. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/73e4191c4ef4
Convert typedef to "using declarations" for flex container's helper classes. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/90fda57adf34
Sort #include declarations in nsFlexContainerFrame.{h,cpp}. r=dholbert

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4a389ce4d36d
https://hg.mozilla.org/mozilla-central/rev/a2d65bda6c55
https://hg.mozilla.org/mozilla-central/rev/2b7adf8582fa
https://hg.mozilla.org/mozilla-central/rev/1830e0579510
https://hg.mozilla.org/mozilla-central/rev/73e4191c4ef4
https://hg.mozilla.org/mozilla-central/rev/90fda57adf34