Closed
Bug 1618944
Opened 5 years ago
Closed 5 years ago
dismiss flag in pref
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
VERIFIED
FIXED
Firefox 75
Tracking | Status | |
---|---|---|
firefox75 | --- | verified |
People
(Reporter: thecount, Assigned: thecount)
References
Details
Attachments
(1 file)
We need to be able to control if a collection is dismissible or not.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → sdowne
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Priority: -- → P1
Assignee | ||
Comment 2•5 years ago
|
||
To test:
Default state:
- Ensure you can see spocs
- Set "browser.newtabpage.activity-stream.discoverystream.spocs-endpoint" to https://spocs.getpocket.com/spocs?site=1116390
- Open a newtab.
Expected: collection should be visible, and should not be dismissible.
Dismissible state.
- Ensure you can see spocs
- Set "browser.newtabpage.activity-stream.discoverystream.spocs-endpoint" to https://spocs.getpocket.com/spocs?site=1116390
- Set "browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible" to true
- Open a newtab.
Expected: Should see collection and should be dismissible.
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/e9fffe1cc28c
Pref for collection dismiss r=gvn
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Comment 5•5 years ago
•
|
||
I have verified that the story collection is available and dismissible after setting the "browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible" pref to "true" and available and not dismissible before the change on Firefox Nightly 75.0a1 Build ID 20200304161940 using Windows 10, Mac 10.14 and Linux Mint 18.3.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•