1617280 - Collection component dismiss

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Right now the work in progress collection component does not have a working dismiss button.

Doing this work likely also means wiring up telemetry for dismiss.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1617280 - Newtab story collections dismiss button

Comment 2

[Gavin Suntop [:gvn] (they/them)]

New requirement from Product: We should control the visibility of the collection dismiss button with a pref in case we need to launch without this functionality or we want to test the usefullness of the dismiss button later on.

(Scott, NI for visibility)

Comment 3

[Scott [:thecount] Downe]

To test:

1. Ensure you can see spocs
2. Set "browser.newtabpage.activity-stream.discoverystream.spocs-endpoint" to https://spocs.getpocket.com/spocs?site=1116390
3. Set "browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible" to true
4. Open a newtab.

expected: You should see a collection on newtabs, above the pocket section.

If you want to dismiss this, you can, if you do that and you want to enable the dismissed items again, do these steps:

1. clear the pref browser.newtabpage.blocked
2. enable browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
3. go to about:home#devtools-ds
4. click refresh cache
5. restart

expected, the collection should be back if you dismissed it.

You can also test test promo just to make sure it did regress during all this. To test that, do these steps:

1. Set browser.newtabpage.activity-stream.discoverystream.endpoints to http,https
2. Set browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://fdfde809-c40b-4dda-96e1-4df41fab3389.mock.pstmn.io/text-promo-layout"}

Expected: You should see a text promo, and you should be able to dismiss it, and clear the dismiss to test again using the same steps used above for collections.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc2d5d677724
Newtab story collections dismiss button r=nanj,gvn

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fc2d5d677724

Comment 6

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following, using Firefox Nightly 75.0a1 (Build ID: 20200302094818) on Windows 10 x64, macOS 10.15, Ubuntu Linux 18.04 x64.

• The “Collection” section is dismissed after the “Dismiss” button was pressed.
• The “Collection” section can be enabled again by following the steps from comment 3.
• The “Text Promo” section is dismissed after the “Dismiss” button was pressed.