Open Bug 1619036 Opened 4 years ago Updated 3 years ago

In full screen mode, the toolbar context menu does not allow toolbar customization or changing bookmarks toolbar visibility

Categories

(Firefox :: Toolbars and Customization, defect, P2)

73 Branch
Desktop
macOS
defect

Tracking

()

Tracking Status
firefox88 --- affected

People

(Reporter: yoodonghoon01, Unassigned)

References

Details

(Whiteboard: [mac:fullscreen:native-affected][mac:fullscreen:nonnative-affected] )

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Open context menu on tool bar in full screen mode.

Actual results:

The context menu shows wrong items.

Expected results:

I expected items like non full screen mode.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Widget: Cocoa
Product: Firefox → Core
Priority: -- → P2
Severity: normal → S3
Whiteboard: [mac:fullscreen]

The issue is still reproducible using Firefox 88.0a1 (20210314213752) on macOS 10.15 and macOS 11.2.3 with full-screen-api.native-full-screen pref on false and true.

Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → macOS
Hardware: Unspecified → Desktop

Markus, could you weigh in on this bug? I believe in order to satisfy users' expectations, the proper fix would need to add the "Exit Fullscreen Mode" context menu entry to the existing toolbar context menu, rather than replacing all other menu items. Is this possible, or did the "context" of the context menu change in such a way (due to being in fullscreen) that we aren't able to do this?

Flags: needinfo?(mstange.moz)
Whiteboard: [mac:fullscreen] → [mac:fullscreen:native-affected][mac:fullscreen:nonnative-affected]

This code seems to intentionally disable the regular toolbar context menu in full screen mode: https://searchfox.org/mozilla-central/rev/6371054f6260a5f8844846439297547f7cfeeedd/browser/base/content/browser-fullScreenAndPointerLock.js#835-836

Dão, do you know why? What's the "breakage" that's being prevented?

Component: Widget: Cocoa → Toolbars and Customization
Flags: needinfo?(mstange.moz) → needinfo?(dao+bmo)
Product: Core → Firefox
Summary: Wrong context menu in full screen mode. (macOS 10.14.6) → In full screen mode, the toolbar context menu does not allow toolbar customization or changing bookmarks toolbar visibility

This goes back to the original implementation from bug 240859 but it doesn't seem to explain. Regardless of the original reasons, I imagine attempting to enable the bookmarks toolbar or title bar (from customize mode) while in fullscreen mode might be problematic on Windows and Linux where we force-hide both bars.

Flags: needinfo?(dao+bmo)

I have this bug right now. I cant right click extensions when in full screen. It only gives the options "Hide toolbar" and "Exit full screen mode".

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: