1619155 - Adding photo to contact fails

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Thomas D. (:thomas8)]

Attachment: Screenshot: failing to add local photo

Adding a photo to a contact not seem to work at all.
Seen on 75.0a1 (2020-02-27) (64-bit).

I'm aware that this is filed against the current (alias "old") AB, but then, we are not sure how many more years to wait for the new AB, and in the meantime, maybe things should not be totally broken like this.

STR

1. In main address book, select "Personal Address Book" (bypass potential problems of "All Address books")
2. New Contact (from AB toolbar), optionally fill name and email, optionally create the contact first and re-edit contact
3. From contact's photo tab, try adding a photo using any of the 3 methods provided.

Actual result:

• checking radio box before adding photo fails, jumps back to "Generic photo"
• With Browse for Local file (On this computer), file name gets added, unreadable bc file icon gets repeated in the background of the input box (see screenshot), radio state doesn't update, photo does not appear (I tried a regular .jpg file which displays correctly elsewhere)
• Same for "On the Web" - nothing
• Same for Drag and drop - nothing

Aceman, any ideas/comments?

Comment 1

[Geoff Lankow (:darktrojan)]

This wasn't really on my list of things to fix today, but I have the solution so might as well.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1619155-contact-photo-1.diff

This fixes the downloading and saving of files, which was broken by bug 1526731. I've also stopped the image icon from filling the background of the file name text box.

I haven't fixed the radio button selection from reverting back to the first item if the others aren't valid, which I think was designed to happen that way, although it is stupid IMO.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9137000 [details] [diff] [review]
1619155-contact-photo-1.diff

Review of attachment 9137000 [details] [diff] [review]:
-----------------------------------------------------------------

Good find. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f38c4f986fa7
Fix contact photo UI. r=mkmelin