1619170 - LinkHandlerChild has a useless "dispatcher" constructor argument

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

All it does with it is pass it to super(), but JSWindowActorChild does not take any constructor arguments.

Possible regression from bug 1592157? Before that it looks like the superclass was ActorChild, which actually does expect a dispatcher.

Comment 1

[Marco Bonardo [:mak]]

While it's true that LinkHandlerChild also handles favicons, it doesn't have an official component, it should likely stay in General, I'm not sure why bug 1592157 ended up here...

Comment 2

[Neil Deakin]

There are several other actors like this as well:

https://searchfox.org/mozilla-central/search?q=super(dispatcher)&case=false&regexp=false&path=

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1619170 - remove useless argument to LinkHandlerChild constructor, r?rpl

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b078e7da213
remove useless argument to LinkHandlerChild constructor, r=rpl

Comment 5

[:Gijs (he/him)]

(In reply to Neil Deakin from comment #2)

There are several other actors like this as well:

https://searchfox.org/mozilla-central/search?q=super(dispatcher)&case=false&regexp=false&path=

Dealing with this in bug 1619630.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3b078e7da213