1619248 - Keyboard shortcut "M" for "Mark read/unread" not shown in Menu and Contextmenu

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[c.buhtz]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

There is a keyobardshort cut "m" that toogles the read status from unread to read and back from unread to read. Works fine.

But it is not shown in the GUI. I would assume that in the "Messages menu" -> "Mark" -> "Unread" / "Read" should the keyboard shortcut visible also.
It is the same for the context menu of a message.

Comment 1

[Wayne Mery (:wsmwk)]

It does seem odd that a short cut is not listed

Comment 2

[Thomas D. (:thomas8)]

(In reply to c.buhtz from comment #0)

There is a keyobardshort cut "m" that toogles the read status from unread to read and back from unread to read. Works fine.

Typo: ... "M" that toggles the read status from unread to read and vice versa, back from read to unread.

But it is not shown in the GUI. I would assume that in the "Messages menu" -> "Mark" -> "Unread" / "Read" should the keyboard shortcut visible also.

Absolutely! Thanks for reporting this.

It is the same for the context menu of a message.

Could you elaborate a little bit why you would wish a shortcut to be displayed in the context menu?
Would you consider it helpful if context menu items would generally expose their respective shortcuts?

(In reply to Wayne Mery (:wsmwk) from comment #1)

It does seem odd that a short cut is not listed

One of my most frequently used shortcuts when handling large numbers of messages. Also to mark messages as unread when I still want to come back to them later. Surprising because all the other shortcuts are there. Might be easy to fix.

Comment 3

[c.buhtz]

(In reply to Thomas D. from comment #2)

Could you elaborate a little bit why you would wish a shortcut to be displayed in the context menu?
Would you consider it helpful if context menu items would generally expose their respective shortcuts?

It is like an in-GUI-manual.
When a user is new to an application she/he first click around to find and use the expected features. This is done by context of course. I want to mark a mail unread: Of course I look into the context-menu of a mail and not of a folder or somewhere else.

While using (context)-menus the user also learn the shortcuts of often used menu entries.

"Normal" users do not read manuals or help pages especially for such a simple task like "What is the shortcut for XYZ?".
RTFM! is a utopic and a bad attitude. Users are lazzy and a bit dump - "Thats reallity Greg!" Even developers are users in some cases - just start to reflect your own behaviour as a user.

In a perfect and pink world a GUI is 100% selfdescribing. Of course this is not reallity but we should try to go/develop into this direction.
Exposing ALL existing shortcuts in the GUI is very easy and should taken as a possibility to reach that goal.

For me (and some other developers) it is a general rule: Featuers should appear or should be accessible from all interface-layers of an application. This means for example everything I can setup in a text-config-file should appear also in the Preferences-Dialog of the application - there should be no difference or hidden options. Also everything I can start from the GUI should be startable via keyboard-shortcut etc - I know it does not make sense in all cases. But a developer should think about it and decide.

Comment 4

[Thomas D. (:thomas8)]

(In reply to c.buhtz from comment #3)

(In reply to Thomas D. from comment #2)

Could you elaborate a little bit why you would wish a shortcut to be displayed in the context menu?
Would you consider it helpful if context menu items would generally expose their respective shortcuts?

It is like an in-GUI-manual.
When a user is new to an application she/he first click around to find and use the expected features. This is done by context of course.
[snip]
Also everything I can start from the GUI should be startable via keyboard-shortcut etc.

+1 to virtually all of comment 3. C.buhtz, thank you very much for your user feedback.

Comment 5

[Liscare]

Attachment: Bug 1619248 - Keyboard shortcut 'M' for 'Mark read/unread' not shown in Menu and Contextmenu. r=thomasD

Comment 6

[Liscare]

Attachment: Context Menu of a Message - UI render with shortcut 'M'

Comment 7

[Liscare]

Attachment: General Menu - UI render with shortcut 'M'

Comment 8

[Thomas D. (:thomas8)]

Liscare, I've reviewed your phabricator patch and requested some minor additions. Would you like to finish this off?

Comment 9

[Liscare]

Sure, I have modified the two remaining files.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/17e51cb10e9c
Keyboard shortcut 'M' for 'Mark read/unread' not shown in Menu and Contextmenu. r=thomasD

Comment 11

[Magnus Melin [:mkmelin]]

Hmm, actually - we don't use hotkeys to context menus, so I think that part should be removed.

Comment 12

[Onno Ekker [:nONoNonO UTC+1]]

It would be nice if this is uplifted to T78...

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9175359 [details]
Bug 1619248 - Keyboard shortcut 'M' for 'Mark read/unread' not shown in Menu and Contextmenu. r=thomasD

(In reply to Magnus Melin [:mkmelin] from comment #11)

Hmm, actually - we don't use hotkeys to context menus, so I think that part should be removed.

That does seem to be true.

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined:
Testing completed (on c-c, etc.): works on beta
Risk to taking this patch (and alternatives if risky): low risk, just a menu item change

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cdcddf1a6300
backout adding hotkey in context menu. r=backout

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9175359 [details]
Bug 1619248 - Keyboard shortcut 'M' for 'Mark read/unread' not shown in Menu and Contextmenu. r=thomasD

[Triage Comment]

Liscare, can you provide a patch for esr that does not contain the context menu bits?

Comment 16

[Liscare]

Attachment: Bug 1619248 - Delete shortcuts for "Mark unread/read" in context menu. r=thomasD

Comment 17

[Liscare]

Done, see the patch D98113.

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9190160 [details]
Bug 1619248 - Delete shortcuts for "Mark unread/read" in context menu. r=thomasD

[Triage Comment]
Approved for esr78

Comment 19

[Rob Lemley [:rjl]]

Comment on attachment 9190160 [details]
Bug 1619248 - Delete shortcuts for "Mark unread/read" in context menu. r=thomasD

[Triage Comment]
This is not right for esr78 as noted in the Phabricator log.

Comment 20

[Liscare]

Attachment: Bug 1619248 - Display keyboard shortcut 'M' for 'Mark read/unread' on applicable menus. r=thomasD

Comment 21

[Thomas D. (:thomas8)]

Comment on attachment 9190160 [details]
Bug 1619248 - Delete shortcuts for "Mark unread/read" in context menu. r=thomasD

(In reply to Rob Lemley [:rjl] from comment #19)

Comment on attachment 9190160 [details]
Bug 1619248 - Delete shortcuts for "Mark unread/read" in context menu. r=thomasD

[Triage Comment]
This is not right for esr78 as noted in the Phabricator log.

Yes, this is obsolete per my review on phabricator with some mentoring how to get this right.

Comment 22

[Thomas D. (:thomas8)]

Comment on attachment 9191164 [details]
Bug 1619248 - Display keyboard shortcut 'M' for 'Mark read/unread' on applicable menus. r=thomasD

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Users have no way to know the important everyday keyboard shortcut for 'Mark read/unread' from the UI.
Testing completed (on c-c, etc.): yes
Risk to taking this patch (and alternatives if risky): low, just adding key attribute to menus

Rob, is there anything else I need to do to get this Phabricator diff (D98690) ready for landing on comm-esr78? I'm a bit irritated that the repository tag is still showing rCOMMCENTRAL comm-central but I couldn't find a more suitable repository from the autocomplete suggestions.

Comment 23

[Rob Lemley [:rjl]]

Comment on attachment 9191164 [details]
Bug 1619248 - Display keyboard shortcut 'M' for 'Mark read/unread' on applicable menus. r=thomasD

Phabricator will always show comm-central, it's just what it does... For fixes to uplift patches, it's usually easier to avoid Phabricator and use Bugzilla's attachments to avoid problems.

[Triage Comment]
This uplift was previously approved for 78.5.1. I verified that the provided patch applies cleanly to c-esr78.

Comment 24

[Rob Lemley [:rjl]]

Thunderbird 78.6.0:
https://hg.mozilla.org/releases/comm-esr78/rev/ba8914bffc01

Comment 25

[WaltS48 [:walts48]]

Verified in testing of the Thunderbird 78.6.0 release candidate on Windows 10.

Keyboard shortcuts appear in the Menu bar and Menu button menus, but not context menu items.