1619378 - Fix wpt failures related to KeyframeEffect with CSS variable and shorthand

Status: NEW

(Core :: DOM: Animation, defect, P3)

Description

[Boris Chiou [:boris]]

There are still some wpt failures related to KeyframeEffect.

KeyframeEffect is constructed or Keyframes are replaced by, or animate() on:

  {
    desc:   'a keyframe sequence with a CSS variable as its property',
    input:  [{ '--custom': 'a' },
             { '--custom': 'b' }],
    output: [keyframe(computedOffset(0), { '--custom': 'a' }),
             keyframe(computedOffset(1), { '--custom': 'b' })]
  },
  {
    desc:   'a property-indexed keyframes specification with a CSS variable as'
            + ' the property',
    input:  { '--custom': ['1', '2'] },
    output: [keyframe(computedOffset(0), { '--custom': '1' }),
             keyframe(computedOffset(1), { '--custom': '2' })]
  },
  {
    desc:   'a two property (one shorthand and one of its shorthand components)'
            + ' two value property-indexed keyframes specification',
    input:  { border: ['pink', '2px'],
              borderColor: ['green', 'blue'] },
    output: [keyframe(computedOffset(0),
                      { border: 'pink', borderColor: 'green' }),
             keyframe(computedOffset(1),
                      { border: '2px', borderColor: 'blue' })],
  },

Comment 1

[Boris Chiou [:boris]]

Looks like these tests are failed on Webkit as well (wpt.fyi).

Comment 2

[Brian Birtles (:birtles)]

I guess some of the failures are due to bug 137688.

For those that are due to us not supporting custom properties, I think we should make the test feature-detect support for custom properties and skip the test if they are not supported. Doing that would mean that:

1. We get a better picture of our support for Web Animations.
2. When we later implement custom properties, if we fail to make animation work properly, we will get an unexpected fail (rather than nothing or an unexpected pass for those tests where our animation support happens to work).

Comment 3

[Boris Chiou [:boris]]

(In reply to Brian Birtles (:birtles) from comment #2)

I guess some of the failures are due to bug 137688.

Perhaps I could take a look at bug 137688 first.

For those that are due to us not supporting custom properties

Is this related to Bug 991950? We don't flip the value at 50% for the custom variables. (i.e. custom variables are not animatable).

I think we should make the test feature-detect support for custom properties and skip the test if they are not supported.

Agree. This is not related to web animations.

Comment 4

[Brian Birtles (:birtles)]

(In reply to Boris Chiou [:boris] from comment #3)

Is this related to Bug 991950? We don't flip the value at 50% for the custom variables. (i.e. custom variables are not animatable).

Yes, that might be a first step. Honestly, I'm not sure how much easier it would be to fix that case without implementing custom properties properly.