1619422 - Provide a CFR action to open about:preferences#sync with an `entryPoint` query parameter

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Matthew N. [:MattN]]

Currently we use OPEN_PREFERENCES_PAGE for CFR_SAVE_LOGIN and while that can select the correct pane with the category property, it doesn't allow passing an entryPoint so any Sync/FxA changes from there won't get attributed to the CFR.

We can either copy the behaviour from the Sync code or call their method for it.

https://searchfox.org/mozilla-central/rev/174f1195ec740e8f17223b48018f7e14e6d4e40e/browser/components/newtab/lib/ASRouter.jsm#1899-1901

Comment 1

[Matthew N. [:MattN]]

Mark, for some reason I thought passing an argument to about:preferences#sync would get it passed to the FxA/Sync sign-up form but then I remember seeing that it wouldn't help get attribution. Should we instead link to a different URL if the user chooses to set up sync from a CFR? See attachment 9082001 [details].

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Sorry, but I don't quite understand the question. I do know that if you call window.gSync.openPrefs("markh-test"), you will end up on the preferences pane with a URL of about:preferences?entrypoint=markh-test#sync. If you then click the "Sign in to Sync" button, you end up on https://accounts.firefox.com/?service=sync&context=fx_desktop_v3&entrypoint=markh-test&action=email

I'd have thought that entrypoint param would help you get attribution - I believe that's used in quite a few key metrics the FxA team tracks. Leif would know more about this, but I haven't needinfo'd him because I suspect I've missed something?

Comment 3

[Matthew N. [:MattN]]

(In reply to Mark Hammond [:markh] [:mhammond] from comment #2)

Sorry, but I don't quite understand the question. I do know that if you call window.gSync.openPrefs("markh-test"), you will end up on the preferences pane with a URL of about:preferences?entrypoint=markh-test#sync. If you then click the "Sign in to Sync" button, you end up on https://accounts.firefox.com/?service=sync&context=fx_desktop_v3&entrypoint=markh-test&action=email

OK, thanks, I thought it worked like that but about a month before I filed this I don't think I could find the code that was doing that and I thought in my test it didn't get passed along. That is what I needed to know.

I'd have thought that entrypoint param would help you get attribution - I believe that's used in quite a few key metrics the FxA team tracks. Leif would know more about this, but I haven't needinfo'd him because I suspect I've missed something?

Nope, that's what I needed to know and it's what I think we should use… not sure why I couldn't find the code or why I didn't think it worked many weeks earlier.

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Bug 1619422 - Provide a CFR action to open about:preferences#sync with an entrypoint query parameter

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b16a5c9e735
Provide a CFR action to open about:preferences#sync with an entrypoint query parameter r=MattN,k88hudson

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7b16a5c9e735

Comment 7

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the "SAVE_LOGIN_72" CFR message redirects to the "about:preferences?entrypoint=cfr-save-login#sync" URL.
Verified using the latest Firefox Nightly (76.0a1 Build ID - 20200319094444) installed on Windows 10 x64, Mac 10.15.3, and Ubuntu 18.04 x64.