1619561 - Search Tips are displayed when Captive Portal notification is displayed

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: captive portal.mp4

[Description:]

According to the experiment documentation link (uncertain if this applies to the "feature" version of Search Tips) , the Search tips should not be displayed when browser notifications are present.

[Environment:]

Windows 10, Mac 10.15.3, Ubuntu 18.04
Firefox Nightly 75.0a1 20200302212732
Firefox 74.0b9 (enabling browser.urlbar.update1.searchTips & browser.urlbar.update1)

[Preconditions:]

1. Create a new profile.
2. Verify that no updates have been made in the last 24h (open about:support, update folder , open folder and delete update.xml if any is listed)
3. Set profile age to be older by running the following snippet in browser console: (async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();
4. Restart browser. (session restore not enabled -> about:newtab default loaded)
5. Default search is google.com.
6. Wi-fi compatible device is connected to a captive portal network.

[Steps:]

1. Browser is opened with the about:newtab.

[Actual Result:]

Onboarding Search Tips are displayed

[Expected Result:]

According to the experiment documentation, given the fact that the Captive Portal notification is present, the Search tips should not be displayed

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1619561 - Don't display Search Tips when when a high-priority notification bar is present. r=harry

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf8af9af8047
Don't display Search Tips when when a high-priority notification bar is present. r=harry

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bf8af9af8047