Closed Bug 1619651 Opened 1 year ago Closed 1 year ago

The "Create New Login" button cannot be focused using the keyboard navigation

Categories

(Firefox :: about:logins, defect, P1)

Product:
Firefox
Component:
about:logins
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 75
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- wontfix
firefox74 --- wontfix
firefox75 --- verified

People

(Reporter: cmuntean, Assigned: mstriemer)

References

(Regression)

Details

(Keywords: access, regression)

Attachments

(2 files)

Create New Login focus.gif
383.49 KB, image/gif
Details
Bug 1619651: Fix focusing of create login button r?MattN
47 bytes, text/x-phabricator-request
Details | Review

[Affected Versions]:

  • Nightly 75.0a1
  • Beta 74
  • Firefox 73.0.1

[Affected Platforms]

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]

  • Have a Firefox profile with logins saved.

[Steps to reproduce]:

  1. Open the Firefox browser with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Press the tab key until the "Create New Login" button is focused.
  4. Observe the behavior.

[Expected results]:

  • The "Create New Login" is correctly focused and remains in this state until the tab key is pressed again.

[Actual results]:

  • The "Create New Login" is focused but the focus automatically jumps to the next item without pressing any key.

[Regression]:

  • Using mozregression tools I have found a pushlog that contains the fix that introduced this behavior.
  • Here are the results:
    Last good revision: ddc25b4c28947b7c89a4d46b127b97bf245cb11a
    First bad revision: ad32f331d00a2c42544570e740e6e6687cd71cd1
    Pushlog: LINK

[Notes]:

  • The issue is also reproducible if no logins are saved.
  • Attached a screen recording with the issue.

Too late to fix a 72 regression in 74, wontfix for this release.

status-firefox73: affected → wontfix
status-firefox74: affected → wontfix

Mark, any chance you have time to look into this regression?

Flags: needinfo?(mstriemer)
Keywords: access
Priority: -- → P1
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fba492bb6fae
Fix focusing of create login button r=jaws

https://hg.mozilla.org/mozilla-central/rev/fba492bb6fae

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox75: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
Status: RESOLVED → VERIFIED
status-firefox75: fixed → verified
You need to log in before you can comment on or make changes to this bug.