1619651 - The "Create New Login" button cannot be focused using the keyboard navigation

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Create New Login focus.gif

[Affected Versions]:

• Nightly 75.0a1
• Beta 74
• Firefox 73.0.1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]

• Have a Firefox profile with logins saved.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Press the tab key until the "Create New Login" button is focused.
4. Observe the behavior.

[Expected results]:

• The "Create New Login" is correctly focused and remains in this state until the tab key is pressed again.

[Actual results]:

• The "Create New Login" is focused but the focus automatically jumps to the next item without pressing any key.

[Regression]:

• Using mozregression tools I have found a pushlog that contains the fix that introduced this behavior.
• Here are the results:
  Last good revision: ddc25b4c28947b7c89a4d46b127b97bf245cb11a
  First bad revision: ad32f331d00a2c42544570e740e6e6687cd71cd1
  Pushlog: LINK

[Notes]:

• The issue is also reproducible if no logins are saved.
• Attached a screen recording with the issue.

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Too late to fix a 72 regression in 74, wontfix for this release.

Comment 2

[Matthew N. [:MattN]]

Mark, any chance you have time to look into this regression?

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1619651: Fix focusing of create login button r?MattN

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fba492bb6fae
Fix focusing of create login button r=jaws

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/fba492bb6fae