Closed Bug 1619852 Opened 5 years ago Closed 5 years ago

Backspace doesn't work in Gmail compose window (and web apps which listenes to mutation events)

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Project Flags:
Root Cause Coding: Logical Error
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox73 --- unaffected
firefox74 --- unaffected
firefox75 blocking fixed

People

(Reporter: birtles, Assigned: masayuki)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1619852 - Fix the mistake in `HTMLEditor::HandleDeleteCollapsedSelectionAtTextNode()` r=m_kato!
47 bytes, text/x-phabricator-request
Details | Review

As of the latest Nightly (a few hours ago) backspace doesn't appear to work in the Gmail compose window.

This reproduces for me on Nightly even after reloading Gmail. Makoto has also been able to reproduce on Windows 10 (Japanese version).

Keywords: regressionwindow-wanted
Regressed by: 1618089
Has Regression Range: --- → yes

Could you look this?

status-firefox74: --- → unaffected
status-firefox75: --- → affected
Flags: needinfo?(masayuki)

Well, I'll take a look.

Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Flags: needinfo?(masayuki)

Maybe part 8?

Must be from the point of regressed build.

Okay, I got it.

The check was written with NS_ASSERTION, but I realized that it's possible
case with mutation event listeners. Therefore, I changed it to if and
return, but I forgot to revert the sign of inequality.

OS: Windows 10 → All
Hardware: x86_64 → All
Summary: Backspace doesn't work in Gmail compose window → Backspace doesn't work in Gmail compose window (and web apps which listenes to mutation events)
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/98c0eaba4024 Fix the mistake in `HTMLEditor::HandleDeleteCollapsedSelectionAtTextNode()` r=m_kato

FYI: You can delete text with selecting the range with Shift + arrow keys for workaround.

Severity: normal → critical
Flags: in-testsuite+
Pushed by malexandru@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/70e8128d86d5 Fix the mistake in `HTMLEditor::HandleDeleteCollapsedSelectionAtTextNode()` r=m_kato

https://hg.mozilla.org/mozilla-central/rev/70e8128d86d5

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox75: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75

FYI, Nightly respins are underway for this bug.

Please specify a root cause for this bug. See :tmaity for more information.

Root Cause: --- → ?
Root Cause: ? → Coding: Logical Error
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: