Support pdb paths with forward slashes
Categories
(Core :: Gecko Profiler, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•5 years ago
•
|
||
What scenarios do these paths arise in? What effect does the patch have in practice?
|
|
Assignee | |
Comment 5•5 years ago
|
||
We're starting to cross-build Firefox for Windows on Linux, in which case the pdb location has a unix path, and then things that use this pdb information and expect a file name are getting the full (irrelevant) path. There's also a telemetry xpcshell test that fails when that happens.
|
|
||
Comment 6•5 years ago
|
||
I see, thanks!
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
What I still don't understand though, is that we can still get the '' character when Firefox is built on Windows, right? (custom builds, etc). From what I understand the patch will break these cases. Am I missing something?
|
|
Assignee | |
Comment 8•5 years ago
|
||
The patch switches to searching for both / and . If it broke native Windows builds, the aforementioned xpcshell test would fail on current Windows builds (Windows tests still run off native builds as of writing).
Description
•