1619865 - Support pdb paths with forward slashes

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1619865 - Support pdb paths with forward slashes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13dd8e1de31e
Support pdb paths with forward slashes. r=gerald

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/13dd8e1de31e

Comment 4

[Markus Stange [:mstange]]

What scenarios do these paths arise in? What effect does the patch have in practice?

Comment 5

[Mike Hommey [:glandium]]

We're starting to cross-build Firefox for Windows on Linux, in which case the pdb location has a unix path, and then things that use this pdb information and expect a file name are getting the full (irrelevant) path. There's also a telemetry xpcshell test that fails when that happens.

Comment 6

[Markus Stange [:mstange]]

I see, thanks!

Comment 7

[Julien Wajsberg [:julienw]]

What I still don't understand though, is that we can still get the '' character when Firefox is built on Windows, right? (custom builds, etc). From what I understand the patch will break these cases. Am I missing something?

Comment 8

[Mike Hommey [:glandium]]

The patch switches to searching for both / and . If it broke native Windows builds, the aforementioned xpcshell test would fail on current Windows builds (Windows tests still run off native builds as of writing).