1620165 - (tier-1-win-cross) Switch win32, win64, win64-aarch64 opt and debug builds to cross-compiles

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Comment 1

[Mike Hommey [:glandium]]

Will do in small pieces so that if bad things happen, we don't necessarily need to backout the entire thing (I probably won't land all at once either).

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Support compiling icudata.asm through Wine.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Prepare win32 mozconfigs for cross-compilation.

The tweaks are essentially the same as for win64 builds, with the only
difference being the path for the VC binary directory.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Prepare win64-aarch64 mozconfigs for cross-compilation.

The tweaks are essentially the same as for win64 builds, with the only
differences being the path for the VC binary directory and the addition
of a WINEPATH for the additional path to load the DLLs necessary to run
asmarm64.exe.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Switch Wine builds to tier 1.

They are going to be required by tier 1 tasks.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Switch win64 opt and debug builds to cross-compiles.

This duplicates the peculiarities of the win64-cross/opt task, while adding
a rust-size dependency it was lacking.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Remove the now redundant win64-cross/opt build.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Switch win32 opt and debug builds to cross-compiles.

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1620165 - Switch win64-aarch64 opt and debug builds to cross-compiles.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07fd2032219c
Support compiling icudata.asm through Wine. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/88e295c52e01
Prepare win32 mozconfigs for cross-compilation. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/7d630d8ef8d4
Prepare win64-aarch64 mozconfigs for cross-compilation. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/a182581fec3f
Switch Wine builds to tier 1. r=dmajor

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/07fd2032219c
https://hg.mozilla.org/mozilla-central/rev/88e295c52e01
https://hg.mozilla.org/mozilla-central/rev/7d630d8ef8d4
https://hg.mozilla.org/mozilla-central/rev/a182581fec3f

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11847e6c1703
Switch win64 opt and debug builds to cross-compiles. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/c19fb753b448
Remove the now redundant win64-cross/opt build. r=dmajor

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a57a40258614
Switch win32 opt and debug builds to cross-compiles. r=dmajor

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92307f8040aa
Switch win64-aarch64 opt and debug builds to cross-compiles. r=dmajor

Comment 15

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/11847e6c1703
https://hg.mozilla.org/mozilla-central/rev/c19fb753b448
https://hg.mozilla.org/mozilla-central/rev/a57a40258614
https://hg.mozilla.org/mozilla-central/rev/92307f8040aa

Comment 16

[Julien Cristau [:jcristau]]

Mike, can/should we back out the parts of this that made it to 75 so we don't have to worry about any issues with the cross builds there?

Comment 17

[Mike Hommey [:glandium]]

I guess you could backout the 4 from comment 15, but they also aren't shipped builds, so I don't think it actually matters.

Comment 18

[Florin Strugariu [:Bebe]]

== Change summary for alert #25340 (as of Thu, 12 Mar 2020 09:46:14 GMT) ==

Improvements:

66% build times windows2012-32 opt taskcluster-c5.4xlarge 1,930.58 -> 662.41
62% build times windows2012-aarch64 debug aarch64 taskcluster-c5.4xlarge 1,773.52 -> 673.58
58% build times windows2012-aarch64 debug aarch64 taskcluster-c5.4xlarge 1,773.44 -> 737.72
58% build times windows2012-64 opt taskcluster-c5.4xlarge 1,824.99 -> 770.46
55% build times windows2012-32 debug taskcluster-c5.4xlarge 1,867.09 -> 832.73
44% build times windows2012-aarch64 opt aarch64 taskcluster-c5.4xlarge 2,688.59 -> 1,505.06

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25340

Comment 19

[Julien Cristau [:jcristau]]

Nevermind this is actually all in 75 afaict...