1619979 - Picture-in-Picture toggle appears on videos that are laid out with small dimensions

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Have a Tidal account
2. Browse to https://listen.tidal.com/view/pages/mymusic_recommended_videos
3. Choose any video to play
4. Click "Minimized" in the top-left corner
5. Hover your mouse over the mini player in the bottom left part of the screen

ER:

No PiP toggle, since the video is so small.

AR:

The PiP toggle appears.

The problem here is that the video element has videoHeight and videoWidth exceeding our heuristic of 160px (140px on Nightly), but is laid out with smaller dimensions (~113px × 64px).

We should use the layout size of the video as part of our heuristics, and not just the videoHeight and videoWidth dimensions.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1619979 - Don't show PiP toggle on videos that have been laid out with small dimensions. r?mstriemer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4184cfc09c3a
Don't show PiP toggle on videos that have been laid out with small dimensions. r=mstriemer

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4184cfc09c3a

Comment 4

[Alin Ilea, Desktop QA]

Reproduced the initial issue in Release version 76.0 using Windows 10.
Verified - Fixed in Beta 77.0b2 (build id: 20200505174119) and latest Nightly 78.0a1 (build id: 20200507085231) on Windows 10 and Ubuntu 18.04.