1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

AboutNewTabService is currently loaded in both the parent and in content processes, which means it does branching based on what process it's currently in.

As part of bug 1614351, I'm going to be increasing some of the responsibilities of the child version, so I think at this point splitting the service out into two fragments makes sense.

AboutNewTabParentService will only run in the parent process, and AboutNewTabChildService will only run in content processes (including the privileged about content process).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I actually think we can probably merge most of the parent-process responsibilities of AboutNewTabService to AboutNewTab.jsm, and get rid of the service entirely in that process.

We'll still need it in the content processes for AboutRedirector to talk to, but a simplified AboutNewTabService that doesn't need all of the parent-process logic.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=Mardak!

This patch does the following:

• Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
• Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
• Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
• Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Comment 3

[Jessilyn Davis]

putting this in the backlog as a P3 to remove from our traige queue - feel free to triage/reassign as you'd like, mconley! :D

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9160f18bc24e
Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 9160f18bc24e (bug 1619992) for XPCshell failures in newtab/test/xpcshell/test_AboutNewTab.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292597564&repo=autoland&lineNumber=2582

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=9160f18bc24e206646df06494bf61d5a75176ff4

Backout:
https://hg.mozilla.org/integration/autoland/rev/02a2f38cab9fd4af3a8197fb2f35fb0300cd5929

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/597d165cd5d3
Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/597d165cd5d3