1620184 - Fix drag/drop functionality in about:downloads to download things

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P3)

Description

[:Gijs (he/him)]

Per bug 978291, this is supposed to work on both the list and the "no downloads" text. That last part I expect broke (at the latest) in bug 1605939.

However, I can't get it to work at all (testing on Windows on beta), dragging either URLs or images from other tabs into either the list or the text - they just replace the about:downloads content with the URL of the dragged item. Maybe I'm doing it wrong? The code and event handlers are still there, it would seem.

Comment 1

[:Gijs (he/him)]

This is just missing a preventDefault() in the shared drag/drop handler.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1620184 - fix drag/drop in about:downloads, r?mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfce436b9982
fix drag/drop in about:downloads, r=mak

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bfce436b9982

Comment 5

[Julien Cristau [:jcristau]]

Do you want to uplift this to 75?

Comment 6

[:Gijs (he/him)]

(In reply to Julien Cristau [:jcristau] from comment #5)

Do you want to uplift this to 75?

It's been broken for ages, I'm not an expert on this code, and we have very little (if any) code coverage, so I'd rather not. It's not that it's risky per se, I'm just becoming more risk averse with these short cycles and apparently nobody having noticed this being broken before...

Comment 7

[abodenlosz]

I was able to reproduce the issue with Firefox 75.0a1 (2020-03-05) on Ubuntu 18.04 x64
Verified the fix with 76.0b6 on Ubuntu 18.04, macOS 10.13 and Windows 10 x64; updating the status to verified.