1620273 - Add SafeRefPtr as a safer variant of a RefPtr

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P2)

Description

[Simon Giesecke [:sg] [he/him]]

Add a safe variant of a RefPtr, which prohibits some unsafe or
unperformant misuses, in particular:

• It is not implicitly convertible from a raw pointer. Unsafe acquisitions
  from a raw pointer must be made using the verbose
  AcquireStrongRefFromRawPtr.
• It does not implicitly decay to a raw pointer. get() must be called
  explicitly.
• It is not copyable, but must be explicitly copied using clone().
• Temporaries cannot be dereferenced using operator* or operator->.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1620273 - Add SafeRefPtr. r=#dom-workers-and-storage

Depends on D65306

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d69cf5fcb571
Add SafeRefPtr. r=asuth,dom-workers-and-storage-reviewers

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 10 changesets (Bug 1623278, Bug 1617170, Bug 1620273, Bug 1597954) for causing bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0e7e76826ace75277a1f892dc14358c675d1c911

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&tochange=0e7e76826ace75277a1f892dc14358c675d1c911&fromchange=50c0e58dd6544fdcf86d5fb99e0895b68446e8c3&selectedJob=293829628

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293829628&repo=autoland&lineNumber=45369

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bcd8d19b32c
Add SafeRefPtr. r=asuth,dom-workers-and-storage-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2bcd8d19b32c