1620289 - Have static clones clone the current selection ranges

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jonathan Watt [:jwatt]]

To print a document we create a "static clone" so that we can print independently of and without freezing the original document (since that can cause various problems). Unfortunately, we aren't actually completely independent of the original document right now.

The main issue in our current implementation of static cloning is that we don't try to copy the selections or the focused frame that were present in the original document. As a result, the code in nsPrintJob keeps a reference to the original document (mOriginalDoc) to get the selections. This is pretty broken since that selection in the original document could change at any time. mOriginalDoc should be killed off.

Note: one issue to keep in mind when fixing this is that we don't want the selection to appear visibly selected in the static clone.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

So the original clone-doc-for-printing patch did clone selection, but I can't find anymore where that code might have moved (or was it removed for some reason?).

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1419739 changed the setup quite a bit.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1620289 - Clone selection ranges when printing r=jwatt,smaug,alaskanemily

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1620289 - Part 1 Clone Selection Ranges For Printing r=jwatt,alaskanemily

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 1620289 - Part 2 Cache Selected Frame For Printing r=jwatt,alaskanemily

• Add new member nsPrintJob::mIsRangeSelection
• Cache mIsRangeSelection and mIsIframeSelected on first call to print

Depends on D71110

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cad73a01b0b2
Part 1 Clone Selection Ranges For Printing r=jwatt

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cad73a01b0b2