1620324 - VoiceOver expects sub-group between HTML Content node and web content

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

STR:

1. Load the following test case: data:text/html,<div>hello<button>world</button>this is more text</div>
2. Launch VoiceOver
3. Enter web content

Expected:
VO says "hello"

Actual:
VO doesn't speak

4. Move VO cursor next with VO+right arrow

Expected:
VO says "world" and VO cursor moves to button

Actual:
VO says "world" but cursor stays on "hello", button has focus outline

Chrome does the first Expected but not the second
Safari matches our behaviour

Comment 1

[Morgan Reschenberg [:morgan]]

This is also true here: https://a11ysupport.io/tests/html/html_label_element_implicit.html

Comment 2

[Morgan Reschenberg [:morgan]]

Given this test case, data:text/html,hello, both Chrome and Safari structure their trees with a group between their web area and web content:

HTML Content > AXGroup > hello (text)

We structure ours:

HTML content > hello (text)

For some reason, when VO enters a content area, it "next"s, causing us to skip the first node. We should insert this pseudogroup as a child of our HTML content to match Safari and Chrome.

Comment 3

[Morgan Reschenberg [:morgan]]

ni'ing you to see if you have thoughts as to what kind of object this group should live on

Comment 4

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1620324: Make INTERNAL_FRAME an AXWebArea, make DOCUMENT an AXGroup. r?eeejay

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1620324 - Part 1: Add mac accessible intermediate root group when needed. r?morgan

When a doc does not have top-level DOM group, or consists of a single leaf,
we need to insert a generated root group. The rotor API expects this and uses
it for boundary detection.

Comment 7

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1620324 - Part 2: Make rotor API work with generated root group. r?morgan

Depends on D90174

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ee894a67a93
Part 1: Add mac accessible intermediate root group when needed. r=morgan
https://hg.mozilla.org/integration/autoland/rev/ea2f00c4049e
Part 2: Make rotor API work with generated root group. r=morgan

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1620324 - Build breakage followup. r?dluca

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/770edab72eb0
Build breakage followup. r=dluca. CLOSED TREE

Comment 11

[Dorel Luca [:dluca]]

Backed out 4 changesets (bug 1665162, bug 1664522, bug 1620324) for XPCshell failures and build bustages. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315878402&repo=autoland&lineNumber=1919

Build bustage:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315876070&repo=autoland&lineNumber=11350

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=ea2f00c4049e3bb28bf0a57edba3eeed15a5445e

Backout:
https://hg.mozilla.org/integration/autoland/rev/42f436b26f0a833b69bb8341c8991828e909bc4e

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2298115ed439
Backed out changeset 770edab72eb0 for XPCshell failures. CLOSED TREE

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1996cd1fd7a6
Part 1: Add mac accessible intermediate root group when needed. r=morgan
https://hg.mozilla.org/integration/autoland/rev/59fd9216fd81
Part 2: Make rotor API work with generated root group. r=morgan

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/1996cd1fd7a6
https://hg.mozilla.org/mozilla-central/rev/59fd9216fd81