1620434 - flexible space is too narrow in the navbar in customize mode

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Dan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

add spacers to the left of the "previous page" button (left of URL bar)

Actual results:

tiny spacers appear in customization-view.

Expected results:

should appear just as wide in customization-view as they appear in bookmark-bar.

Comment 1

[Marcela (Please NI request to Brindusa Tot)]

Attachment: Customize_spaces .png

Comment 2

[Marcela (Please NI request to Brindusa Tot)]

I was able to reproduce this issue on latest Nightly version 75.0a1 (2020-03-09) on Windows 10. I attached a file and changed the component accordingly.

Comment 3

[:Gijs (out for now; he/him)]

Attachment: Bug 1620434 - increase default sizing of the spacers in the navbar in customize mode again, r?dao

Comment 4

[:Gijs (out for now; he/him)]

final beta builds for 74 have been built so a fix here won't make 74.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/adffa9dc4864
increase default sizing of the spacers in the navbar in customize mode again, r=dao

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/adffa9dc4864

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[:Gijs (out for now; he/him)]

Comment on attachment 9132018 [details]
Bug 1620434 - increase default sizing of the spacers in the navbar in customize mode again, r?dao

Beta/Release Uplift Approval Request

• User impact if declined: Spacer sizing is off in the navbar in customize mode
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small CSS fix to make spacer sizing more sane/obvious
• String changes made/needed: nope

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9132018 [details]
Bug 1620434 - increase default sizing of the spacers in the navbar in customize mode again, r?dao

approved for 75.0b3

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2106e4256e2b

Comment 11

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly from 2020-03-05 on Windows 10 x64.
I retested everything using latest Nightly 76.0a1 and beta 75.0b3 on Windows 10 x64, macOS 10.15 and Ubuntu 16.04 x64. The issue is not reproducing anymore.