1620515 - Extract entry reader&writer out of BlocksRingBuffer

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

The entry reader&writer can be moved outside of BlocksRingBuffer.
The new fission-friendly storage will be able to use these classes directly, which will ease the transition.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1620515 - Revert order of BlocksRingBuffer (de)serializer declarations - r?canaltinova!,gregtatum

Only reordering declarations, to make the next patch easier to read.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1620515 - ProfileBufferEntrySerialization.h with (de)serializers - r?canaltinova!,gregtatum

ProfileBufferEntrySerialization.h will contain the entry reader and writer.

This patch creates the file with renamed copies of the (de)serializers from
BlocksRingBuffer; there shouldn't be significant code changes, this hg cp will
help keep their history. See next patch for how they will actually be used.

Depends on D65694

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1620515 - ProfileBufferEntryReader and ProfileBufferEntryWriter - r?canaltinova!,gregtatum

Actual implementation of the entry reader and writer.
They expose a very similar API as the original BlocksRingBuffer entry reader&
writer.

(No tests here; In the next patch they will get used instead of the old reader&
writer, and will hence inherit all relevant tests.)

Depends on D65695

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1620515 - Replace BlocksRingBuffer::EntryReader/Writer with ProfileBufferEntryReader/Writer - r?canaltinova!,gregtatum

The new ProfileBufferEntryReader/Writer are now used everywhere, including in
the profilers and tests.
The old EntryReader/Writer have been removed.

Depends on D65696

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5ff9d8d43ec
Revert order of BlocksRingBuffer (de)serializer declarations - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/6dd083a1efc1
ProfileBufferEntrySerialization.h with (de)serializers - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/b8005deff29e
ProfileBufferEntryReader and ProfileBufferEntryWriter - r=canaltinova
https://hg.mozilla.org/integration/autoland/rev/aee1b0159e7e
Replace BlocksRingBuffer::EntryReader/Writer with ProfileBufferEntryReader/Writer - r=canaltinova

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b5ff9d8d43ec
https://hg.mozilla.org/mozilla-central/rev/6dd083a1efc1
https://hg.mozilla.org/mozilla-central/rev/b8005deff29e
https://hg.mozilla.org/mozilla-central/rev/aee1b0159e7e