Closed Bug 1620542 Opened 24 days ago Closed 23 days ago

Turn on ESLint for .eslintrc.js files

Categories

(Firefox Build System :: Lint and Formatting, task, P2)

task
Points:
2

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Iteration:
75.2 - Feb 24 - Mar 8
Tracking Status
firefox75 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Linting will be on by default for .eslintrc.js files in ESLint 7.0.0.

There's been discussions on this before (xref bug 1563927), and I think it is a reasonable thing to have, as having editor linting helps developers changing these files, and also means we use the same format as our normal code.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 76.1 - Mar 9 - Mar 22
Points: --- → 2
Iteration: 76.1 - Mar 9 - Mar 22 → 75.2 - Feb 24 - Mar 8

Please note, I'm going ahead and landing this with Dave Townsend's review and not waiting for the (automatically added) blocking reviews, as this is automated formatting changes only to configuration files, and I'd like to land during the quiet time of the soft freeze before the merges.

If this causes issues, please let me know.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efdbe31f5e2a
Automatically fix ESLint errors in .eslintrc.js files. r=mossop
https://hg.mozilla.org/integration/autoland/rev/0489a3d16f95
Turn on linting of .eslintrc.js files. r=mossop
Status: ASSIGNED → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.