1620542 - Turn on ESLint for .eslintrc.js files

Status: RESOLVED FIXED

(Firefox Build System :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

Linting will be on by default for .eslintrc.js files in ESLint 7.0.0.

There's been discussions on this before (xref bug 1563927), and I think it is a reasonable thing to have, as having editor linting helps developers changing these files, and also means we use the same format as our normal code.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r?Mossop

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1620542 - Turn on linting of .eslintrc.js files. r?Mossop

Depends on D65703

Comment 3

[Mark Banner (:standard8)]

Please note, I'm going ahead and landing this with Dave Townsend's review and not waiting for the (automatically added) blocking reviews, as this is automated formatting changes only to configuration files, and I'd like to land during the quiet time of the soft freeze before the merges.

If this causes issues, please let me know.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efdbe31f5e2a
Automatically fix ESLint errors in .eslintrc.js files. r=mossop
https://hg.mozilla.org/integration/autoland/rev/0489a3d16f95
Turn on linting of .eslintrc.js files. r=mossop

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/efdbe31f5e2a
https://hg.mozilla.org/mozilla-central/rev/0489a3d16f95