1620537 - Upgrade to ESLint 7.x

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P2)

Description

[Mark Banner (:standard8)]

ESLint 7 is in the works (currently alpha 2).

At this stage there doesn't look to be much that is actually breaking, though they are turning on more rules in the recommended config, and enabling linting of .eslintrc.js files by default.

Seeing as those rules and capabilities already exist, I think it would be good to get work started on those ahead of the release, to make upgrading easier.

Comment 1

[Mark Banner (:standard8)]

Going to take this and turn it into an implementation bug rather than a meta - bug 1620552 can be done after this one and we'll probably use mentored bugs for it.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1620537 - Disable no-setter-return where it is failing pending future re-enabling. r?Mossop!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1620537 - Fix eslint issues in devtools .eslintrc*.js files now that ESLint 7 will lint them. r?Mossop!

Depends on D84815

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1620537 - Fix more ESLint issues raised after upgrading to ESlint 7. r?Mossop!

There's two issues being fixed here - the first is that no-unused-vars now reports against the last instance of the unused variable. The second is no-dupe-else-if is now on by default.

Depends on D84816

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1620537 - Fix issues in eslint-plugin-mozilla rules that were raised in ESLint 7. r?Mossop!

Depends on D84818

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 1620537 - Upgrade to ESLint 7.5.0, remove now unnecessary Babel plugins. r?Mossop!

Depends on D84819

Comment 7

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ec6bf59623906d4b5adb4a626178a8388bab2fa&selectedTaskRun=Pf-ooNfRTGGpo9-bhsX26A.0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c073842299d
Disable no-setter-return where it is failing pending future re-enabling. r=mossop
https://hg.mozilla.org/integration/autoland/rev/377c6af23652
Fix eslint issues in devtools .eslintrc*.js files now that ESLint 7 will lint them. r=mossop
https://hg.mozilla.org/integration/autoland/rev/ca98135c331b
Fix more ESLint issues raised after upgrading to ESlint 7. r=mossop
https://hg.mozilla.org/integration/autoland/rev/b9a6c2958b1c
Fix issues in eslint-plugin-mozilla rules that were raised in ESLint 7. r=mossop
https://hg.mozilla.org/integration/autoland/rev/2d8ae00226d3
Upgrade to ESLint 7.5.0, remove now unnecessary Babel plugins. r=mossop

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7c073842299d
https://hg.mozilla.org/mozilla-central/rev/377c6af23652
https://hg.mozilla.org/mozilla-central/rev/ca98135c331b
https://hg.mozilla.org/mozilla-central/rev/b9a6c2958b1c
https://hg.mozilla.org/mozilla-central/rev/2d8ae00226d3